[IMP] Add QRcode in printer_zpl2 module #105

sla-subteno-it · 2017-09-06T10:10:09Z

Add new barcode (QR Code format) in printer_zpl2 module

oca-clabot · 2017-09-12T15:31:05Z

Hey @alnslang, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

@aurimukas (login unknown in OCA database)

Appreciation of efforts,
OCA CLAbot

Garamotte · 2017-12-06T12:36:28Z

printer_zpl2/models/printing_label_zpl2_component.py

+            (zpl2.QRMODEL_ENHANCED, 'Enhanced'),
+        ], required=True, default=zpl2.QRMODEL_ENHANCED,
+        help='Model')
+    qrmagnification = fields.Selection(


Replace by a simple Integer field and rename to magnification_factor.

Garamotte · 2017-12-06T12:36:58Z

printer_zpl2/models/printing_label_zpl2.py

@@ -84,6 +84,7 @@ def _generate_zpl2_components_data(
        for (component, data, offset_x, offset_y) in to_print:
            component_offset_x = component.origin_x + offset_x
            component_offset_y = component.origin_y + offset_y
+


Remove the unneeded empty line.

Garamotte · 2017-12-06T12:42:38Z

printer_zpl2/models/printing_label_zpl2.py

@@ -127,6 +128,23 @@ def _generate_zpl2_components_data(
                    label_data, data,
                    label_offset_x=component_offset_x,
                    label_offset_y=component_offset_y)
+            elif component.component_type == zpl2.BARCODE_QRCODE:
+                # Adding Control Arguments to QRCode data Label
+                data = 'MM,A{}'.format(data)


The section (else) already calls the barcode_data method.
Move the custom data change into the else to avoid duplicating code.

You will simply have to add the new arguments added by the QR Code format in the arguments list, as the barcode_data already filters the arguments to take in account depending on the barcode type.

Garamotte · 2017-12-06T12:48:21Z

printer_zpl2/models/printing_label_zpl2_component.py

@@ -142,3 +143,36 @@ class PrintingLabelZpl2Component(models.Model):
    block_left_margin = fields.Integer(
        string='Left Margin',
        help='Left margin for the second and other lines in the block.')
+    qrmodel = fields.Selection(


Rename to model.

Garamotte · 2017-12-06T12:48:35Z

printer_zpl2/models/printing_label_zpl2_component.py

+            (zpl2.QRMAGNIFICATION_1000DPI, '1000 Dpi'),
+        ], required=True, default=zpl2.QRMAGNIFICATION_300DPI,
+        help='Magnification Factor')
+    qrerrorcorrection = fields.Selection(


Rename to error_correction.

Garamotte · 2017-12-06T12:48:43Z

printer_zpl2/models/printing_label_zpl2_component.py

+            (zpl2.QRERRORCORRECTION_HIGH_DENSITY, 'High density level'),
+        ], required=True, default=zpl2.QRERRORCORRECTION_HIGH,
+        help='Error Correction')
+    qrmask = fields.Integer(


Rename to mask_value.

Garamotte · 2017-12-06T12:50:37Z

printer_zpl2/views/printing_label_zpl2.xml

@@ -81,6 +81,15 @@
                                    <field name="truncate"/>
                                </group>
                            </page>
+                            <!-- QRCode arguments -->
+                            <page string="QRCode Arguments" attrs="{'invisible': [('component_type', '!=', 'qrcode')]}">


Change the string to 2D Barcode Arguments to be more generic.

Garamotte · 2017-12-15T16:18:39Z

All changes done.

@pedrobaeza The CLA should be OK, can the bot recheck ?

pedrobaeza · 2017-12-15T16:19:21Z

With a new commit from the person a message will be put about the validity

oca-clabot · 2017-12-20T15:17:47Z

Hey @alnslang,
We acknowledge that the following users have signed our Contributor License Agreement:

@aurimukas

Appreciation of efforts,
OCA CLAbot

aurimukas · 2018-01-10T16:19:07Z

@pedrobaeza could you validate this pull request as well please ?

pedrobaeza · 2018-01-11T09:52:08Z

Sorry, but I don't know about this module. Other should be the reviewer.

Garamotte · 2018-01-11T09:56:22Z

@JosDeGraeve Maybe you can look at this and test the PR ?

JosDeGraeve · 2018-01-11T13:45:41Z

@sylvain-garancher i'll try - please remind me if it takes too long :)

sla-subteno-it · 2018-01-14T23:49:12Z

Thanks @fmdl

aurimukas · 2018-01-16T10:28:26Z

Hello @pedrobaeza can we merge the request please ?

pedrobaeza · 2018-01-16T10:32:02Z

The problem I see with this is that current working installations with zpl2 version 1.0 won't work after this update, which goes against same version stability.

What do you think, @sylvain-garancher ?

Garamotte · 2018-01-16T11:06:10Z

@pedrobaeza The requirements file has been updated, so this is an issue only if the install doesn't respect the requirements, is this still blocking for you ?

pedrobaeza · 2018-01-16T11:13:05Z

Yes. Someone that has a deployment working, updating this repository will find that it's not working anymore.

sla-subteno-it · 2018-01-17T16:19:54Z

@pedrobaeza What solution do you propose to accept this PR?

lmignon · 2018-01-17T16:29:19Z

@pedrobaeza It's a nice improvement, we must find a way to not block this kind of change. IMO it's not blocking but the change of the minimal version required for the module should be mentioned into the README.

lmignon · 2018-01-17T16:39:10Z

@alnslang Can you also modify the setup.py file of this module to enforce the minimal version of spl2 plz as follow:
https://github.com/OCA/report-print-send/blob/10.0/setup/printer_zpl2/setup.py

setuptools.setup(
    setup_requires=['setuptools-odoo'],
    odoo_addon={
        'external_dependencies_override': {
            'python': {
                'zpl2': 'zpl2>=1.1',
            },
        },
    },
)

With this change the upgrade will be automatic for those using pip to install the addons.
You should also mention the minimal version required for this external dependency into the README file.

lasley

Thank you for the improvemenet @alnslang

In the case of a library version mismatch, can you explain to me what the error is? From reading the code, I am guessing that the error would trigger any time that a label is printed? Am I correct in that guess?

pedrobaeza · 2018-01-17T17:06:58Z

OK, then go ahead. I'm not a direct user of this module, but I was trying to avoid breaking installations. If you say that there's no problem or it's an acceptable risk, then I won't block anymore.

lasley · 2018-01-17T17:10:06Z

printer_zpl2/README.rst

@@ -15,6 +15,7 @@ See below for more details.
 Installation
 ============

+This module requires zpl2 >= version 1.1.


Instead of just noting the requirement, we need to state this as an upgrade note. Users upgrading pre-existing installations are the ones that this affects, not new users. As such, I recommend:

**Upgrade Note:** If upgrading from a version prior to 10.0.2.0.0, you must make sure to update the `zpl2` Python package to at least version 1.1.

Also, please bump the module version by a major version: 10.0.2.0.0

github-actions · 2021-10-31T12:00:42Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

Syncing from upstream OCA/report-print-send (15.0)

sla-subteno-it force-pushed the 10.0-add-qrcode-printer_zpl2 branch 2 times, most recently from 1fec5a0 to 80a92a6 Compare September 6, 2017 14:51

Garamotte force-pushed the 10.0-add-qrcode-printer_zpl2 branch from dabcbcd to 1b12155 Compare October 2, 2017 15:09

Garamotte suggested changes Dec 6, 2017

View reviewed changes

Garamotte force-pushed the 10.0-add-qrcode-printer_zpl2 branch from 1b12155 to ac5862a Compare December 15, 2017 16:16

Garamotte force-pushed the 10.0-add-qrcode-printer_zpl2 branch from ac5862a to 8316da5 Compare December 20, 2017 15:17

[IMP] Add QRcode in printer_zpl2 module

8dd56b9

Garamotte force-pushed the 10.0-add-qrcode-printer_zpl2 branch from 8316da5 to 8dd56b9 Compare December 20, 2017 15:58

Garamotte approved these changes Jan 3, 2018

View reviewed changes

fmdl approved these changes Jan 14, 2018

View reviewed changes

lasley reviewed Jan 17, 2018

View reviewed changes

[IMP] Force minimal version of zpl2 external dependency

f821f51

sla-subteno-it force-pushed the 10.0-add-qrcode-printer_zpl2 branch from 071befc to f821f51 Compare January 17, 2018 17:15

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 31, 2021

github-actions bot closed this Dec 5, 2021

nikolausweingartmair pushed a commit to nikolausweingartmair/report-print-send that referenced this pull request Nov 2, 2022

Merge pull request OCA#105 from OCA/15.0

d216b2e

Syncing from upstream OCA/report-print-send (15.0)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IMP] Add QRcode in printer_zpl2 module #105

[IMP] Add QRcode in printer_zpl2 module #105

sla-subteno-it commented Sep 6, 2017

oca-clabot commented Sep 12, 2017

Garamotte Dec 6, 2017

Garamotte Dec 6, 2017

Garamotte Dec 6, 2017

Garamotte Dec 6, 2017

Garamotte Dec 6, 2017

Garamotte Dec 6, 2017

Garamotte Dec 6, 2017

Garamotte commented Dec 15, 2017

pedrobaeza commented Dec 15, 2017

oca-clabot commented Dec 20, 2017

aurimukas commented Jan 10, 2018

pedrobaeza commented Jan 11, 2018

Garamotte commented Jan 11, 2018

JosDeGraeve commented Jan 11, 2018

sla-subteno-it commented Jan 14, 2018

aurimukas commented Jan 16, 2018

pedrobaeza commented Jan 16, 2018

Garamotte commented Jan 16, 2018

pedrobaeza commented Jan 16, 2018

sla-subteno-it commented Jan 17, 2018

lmignon commented Jan 17, 2018

lmignon commented Jan 17, 2018

lasley left a comment

pedrobaeza commented Jan 17, 2018

lasley Jan 17, 2018

github-actions bot commented Oct 31, 2021

[IMP] Add QRcode in printer_zpl2 module #105

[IMP] Add QRcode in printer_zpl2 module #105

Conversation

sla-subteno-it commented Sep 6, 2017

oca-clabot commented Sep 12, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Garamotte commented Dec 15, 2017

pedrobaeza commented Dec 15, 2017

oca-clabot commented Dec 20, 2017

aurimukas commented Jan 10, 2018

pedrobaeza commented Jan 11, 2018

Garamotte commented Jan 11, 2018

JosDeGraeve commented Jan 11, 2018

sla-subteno-it commented Jan 14, 2018

aurimukas commented Jan 16, 2018

pedrobaeza commented Jan 16, 2018

Garamotte commented Jan 16, 2018

pedrobaeza commented Jan 16, 2018

sla-subteno-it commented Jan 17, 2018

lmignon commented Jan 17, 2018

lmignon commented Jan 17, 2018

lasley left a comment

Choose a reason for hiding this comment

pedrobaeza commented Jan 17, 2018

Choose a reason for hiding this comment

github-actions bot commented Oct 31, 2021