[MIG][11.0] Migrate base_report_to_printer

[Garamotte]

Migration of the base_report_to_printer module to v11.0 (currently tested on master as the 11.0 branch has not already been created on Odoo's repo).

[gdgellatly]

@sylvain-garancher et al, lets work to get this done. If you are busy I can take over. I think its nearly there.

[Garamotte]

Yes, sorry, I'm very busy at the moment...
You can fix the latest things discussed here in your PR that merges printer_tray into base_report_to_printer, and I'll close this one.

[gdgellatly]

@sylvain-garancher I missed this, anyway I was just doing something else and I noticed they refactored the web client post release, so the js is going to need to change now anyway as there is no more web.Model

[gdgellatly]

@lasley Can I ask you for a quick bit of help please. In this module we had a javascript call to select the action, either print or send to client. With changes to the web client it is no longer valid and I can't work out how it needs to be changed to still work. Do you know how to call a models method in 11.0 web client?

[lasley]

@gdgellatly - Sure, can you point me to the old code we're trying to replace?

[lasley]

@gdgellatly Is this what we're replacing?

[gdgellatly]

@lasley Yes,

web.Model no longer exists, I tried a straight swap with Basic and Abstract but no dice. The call method fails so I'm guessing its a bit more complicated than that. When I debug it, I see that the args are being passed as the main arguments, instead of the method and method args.

[lasley]

@gdgellatly - sweet thanks for the elaboration. And when you say you used the basic and abstract, you're referring to web.BasicModel?

From what I understand, the models just allow for the basic CRUD operations. You've honestly got me if there is a new entrypoint for any method call, but I think an easy solution here would just be to use RPC directly instead:

var rpc = require('web.rpc');
...
rpc.query({
    model: 'ir.actions.report',
    method: 'print_action_for_report_name',
    args: [action_val.report_name]
}).then(...

[gdgellatly]

@lasley Thanks. Yes its quite different now and completely undocumented and I never really understood the last one, so not having fun. I'm going with what you did. That was very close to my hackish attempts.

[lasley]

If I understand correctly, things would be different if we actually had a record to attach to. I haven't actually tried it, but I feel like you can require('web.BasicModel').get(id).a_method(arg1, arg2)

[gdgellatly]

@lasley thanks it worked, I've done up the outstanding details of this PR and done a full review and pushed to #110 as a single PR

[Garamotte]

I close this PR to avoid splitting the conversations :)
Superseded by #110