[10.0] Pingen migration #114
Conversation
pingen/__init__.py
Outdated
| # Author: Guewen Baconnier | ||
| # Copyright 2012 Camptocamp SA | ||
| # Author: Anar Baghirli | ||
| # Copyright 2017 Camptocamp SA |
There was a problem hiding this comment.
-
Don't change the author, you are not the original author of that module.
You can add your name as contributor in the README.rst
It's probably not what you meant to do but this is like stealing the work of someone else.
Add only your name as author if you are adding a functionnality or a major work in the code. -
Dates shouldn't be erased, it should list the years of edition in this case 2012, 2017
-
Use the following format for headers:
https://github.com/OCA/maintainer-tools/blob/master/template/module/__openerp__.py#L1-L3
|
Please do a |
abaghirli
force-pushed
the
BSIN7-219_pingen_migrate_10
branch
from
b47ed0e
to
ac0e9d1
Compare
pingen/ir_attachment.py
Outdated
| elif attachment.type == 'url': | ||
| response = requests.get(attachment.url) | ||
| if self.type == 'binary': | ||
| decoded_document = self.datas |
There was a problem hiding this comment.
Can you explain why this should no longer be decoded? BTW the method name is _decoded_content so it isn't consistent.
There was a problem hiding this comment.
it should be decoded. but not by base64.decodestring. that was the reason i got unreadable document.
There was a problem hiding this comment.
attachment_id not needed Pingen get_pingen_session fixed
abaghirli
force-pushed
the
BSIN7-219_pingen_migrate_10
branch
from
643db4f
to
078832c
Compare
yvaucher
changed the title
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
No description provided.