Migration of base_report_to_printer #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guewen
force-pushed
the
8.0-base_report_to_printer-migr
branch
2 times, most recently
from
a462b59
to
43640a1
Compare
Replace it by a database lock so the different processes are all aware of the lock and the last update timestamp.
guewen
force-pushed
the
8.0-base_report_to_printer-migr
branch
from
43640a1
to
b7e1303
Compare
1 similar comment
| } | ||
|
|
||
| # vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4: | ||
| printing_action = fields.Selection(_user_available_action_types) |
There was a problem hiding this comment.
Field string 'Printing Action' was removed intentionally ?
There was a problem hiding this comment.
Yes.
As advised in https://www.odoo.com/documentation/8.0/reference/orm.html in Porting from the old API:
if a field’s string is the titlecased version of the field name:
name = fields.Char(string="Name")
it is useless and should be removed
|
I will make a few changes (extract a method at least) to reduce the code in printer_tray. |
See odoo/odoo#3644 Also, it helps to have the value set/read in context close to each other.
printers needs to be refreshed. Keep the last update datetime in cache and invalidate this datetime if is is older than POLL_INTERVAL. Thus, one process won't hit the DB more than 1 time every POLL_INTERVAL (10 seconds currently) to check if it needs to update the list.
guewen
force-pushed
the
8.0-base_report_to_printer-migr
branch
from
f659a39
to
5805a6f
Compare
guewen
force-pushed
the
8.0-base_report_to_printer-migr
branch
from
eae5341
to
caa9edb
Compare
|
Done. |
|
There is an issue on install: Programming error: relation "printing_printer_polling" does not exist |
guewen
force-pushed
the
8.0-base_report_to_printer-migr
branch
2 times, most recently
from
ba4f670
to
d46d9b7
Compare
guewen
force-pushed
the
8.0-base_report_to_printer-migr
branch
from
d46d9b7
to
2cc8ae8
Compare
|
@yvaucher I fixed it |
|
👍 |
|
but my last commit is bad |
method returns a fresh value after creation of the table
|
Pushed the fix. |
|
👍 Thanks for the conversion to new API. |
pedrobaeza
added a commit
that referenced
this pull request
Nov 19, 2014
Migration of base_report_to_printer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration of base_report_to_printer
reportmodule, but only thepdfones, not implemented forhtmlreports, I don't think that's useful)Lock()local to the process and replaced it by a database lock so the processes share the same lock and last update timestamp