[MIG] Migrated base_report_to_printer_mail to 8.0 #89
Conversation
| @@ -0,0 +1,43 @@ | |||
| # -*- coding: utf-8 -*- | |||
| ############################################################################## | |||
There was a problem hiding this comment.
Please use the short header, like in the template : https://github.com/OCA/maintainer-tools/blob/master/template/module/__openerp__.py
| 'description': """ | ||
|
|
||
| """, | ||
| 'images': [], |
| @@ -0,0 +1,33 @@ | |||
| # -*- coding: utf-8 -*- | |||
| ############################################################################## | |||
| import logging | ||
| _logger = logging.getLogger(__name__) | ||
|
|
||
| class email_template(osv.osv): |
There was a problem hiding this comment.
Prefer using models.Model instead of osv.osv since v8.0.
| class email_template(osv.osv): | ||
| _inherit = "email.template" | ||
|
|
||
| def generate_email_batch(self, cr, uid, template_id, res_ids, context={}, fields=None): |
There was a problem hiding this comment.
Don't use context={} but context=None instead.
More information about that:
| """, | ||
| 'images': [], | ||
| 'author': 'Vertel AB', | ||
| 'website': 'http://www.vertel.se, Odoo Community Association (OCA)', |
There was a problem hiding this comment.
OCA should be in the author key instead of website.
|
And you should preserve commit history. Use https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-9.0 switching the branches names. |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
No description provided.