Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] report_custom_filename #10

Merged
merged 2 commits into from
Jan 23, 2015
Merged

Conversation

hbrunn
Copy link
Member

@hbrunn hbrunn commented Dec 19, 2014

only ir.actions.report.xml up to now, but it should be simple to figure out where to do that for qweb reports

@coveralls
Copy link

Coverage Status

Coverage increased (+3.14%) when pulling 63bc58a on hbrunn:8.0-report_custom_filename into 0e1368f on OCA:8.0.

"license": "AGPL-3",
"complexity": "normal",
"description": """
This addon allows for custom filenames for reports. Currently, only old-style
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this in a README.rst file for being used by GitHub and Odoo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for the comment.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedrobaeza
Copy link
Member

Very interesting module. Can this be backported to 7.0 easily?

@hbrunn
Copy link
Member Author

hbrunn commented Dec 20, 2014

not verbatim, because report generation was quite a bit revamped in 8. also you'd have to monkey patch the controller because orm-style inheritance is new in 8

@nhomar
Copy link
Member

nhomar commented Dec 20, 2014

Solved the readme stuff. ILGTM.

@guewen
Copy link
Member

guewen commented Dec 23, 2014

👍

@hbrunn
Copy link
Member Author

hbrunn commented Jan 23, 2015

@pedrobaeza @nhomar @yvaucher thanks for your input, there's a README.rst now

@yvaucher
Copy link
Member

👍 Thanks

@coveralls
Copy link

Coverage Status

Coverage increased (+3.14%) to 29.33% when pulling 4bc87ce on hbrunn:8.0-report_custom_filename into 0e1368f on OCA:8.0.

@pedrobaeza
Copy link
Member

👍

pedrobaeza added a commit that referenced this pull request Jan 23, 2015
@pedrobaeza pedrobaeza merged commit 57b5d10 into OCA:8.0 Jan 23, 2015
lmignon pushed a commit to acsone/reporting-engine that referenced this pull request Oct 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants