Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unified COPYRIGHT & LICENSE. #18

Merged
merged 1 commit into from Jul 22, 2015
Merged

Add unified COPYRIGHT & LICENSE. #18

merged 1 commit into from Jul 22, 2015

Conversation

yajo
Copy link
Member

@yajo yajo commented Jul 3, 2015

This repository lacks a LICENSE file, and that must be fixed.

By the way, based in the logic of upstream Odoo, GPL headers are not required nowadays, so less garbage in files is always nice.

I imagine this can cause some controversial, but if you want the garbage please at least add the LICENSE & COPYRIGHT or I will not submit code here.

@yajo yajo mentioned this pull request Jul 3, 2015
@yajo
Copy link
Member Author

yajo commented Jul 3, 2015

I decided to split in two commits. The first adds LICENSE, with IMHO is required. I think anyone understands that sending code to a repository without a proper LICENSE is somehow uncomfortable.

The second commit handles and explains the unification.

In case you don't want the second, at least pick up the first one please.

@pedrobaeza
Copy link
Member

You should remove COPYRIGHT file, as this is not really true. The copyright is of the corresponding people. OCA has through the CLA some rights only. Look at the template for a repo here: https://github.com/OCA/maintainer-quality-tools/tree/master/sample_files

@pedrobaeza
Copy link
Member

All rights reserved is an outdated expression

@yajo
Copy link
Member Author

yajo commented Jul 6, 2015

Sorry, the COPYRIGHT stuff was something I thought it could be useful, and I based it in the upstream movements. IANAL, but surely Odoo have good ones.

Anyway, it's away now. At least LICENSE should be required.

@yajo
Copy link
Member Author

yajo commented Jul 22, 2015

I understand changing copyright headers can be cumbersome, and it's not much needed after all. I removed that commit. At least merge the license please.

@yvaucher
Copy link
Member

👍 I proceed with the merge as LICENSE file should be there in each OCA repo

yvaucher added a commit that referenced this pull request Jul 22, 2015
@yvaucher yvaucher merged commit cfb54b9 into OCA:8.0 Jul 22, 2015
@yajo yajo deleted the license branch July 22, 2015 11:19
@yajo yajo mentioned this pull request Jul 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants