Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] support qweb reports #22

Merged
merged 1 commit into from
Sep 11, 2015
Merged

Conversation

hbrunn
Copy link
Member

@hbrunn hbrunn commented Aug 24, 2015

No description provided.

Usage
=====

To use this module, you need to:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this sentence. It's intended as template to explain the usage, not as an introduction to the "Try me on runbot" button

@pedrobaeza
Copy link
Member

There's a linter error:

./report_custom_filename/controllers/report_controller.py:39:13: F402 import 'report' from line 22 shadowed by loop variable

@@ -8,12 +8,6 @@ Configuration

To configure this module, open the report whose filename you want to change and fill in the `Download filename` field. This field is evaluated as jinja2 template with `objects` being a list of browse records of the records to print, and `o` the first record.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you take the occasion to put here an example of a simple jinja2 example (for instance ${o.name + '_report'})?

@pedrobaeza
Copy link
Member

Tested on runbot and functionally working.

@hbrunn
Copy link
Member Author

hbrunn commented Aug 31, 2015

@pedrobaeza thanks, all done

from openerp.addons.email_template import email_template


class ReportController(addons.report.controllers.main.ReportController):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an error on Travis. Maybe addons is twice imported? Use FQN to see

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedrobaeza thanks and sorry for the noise, I'm flying blindy currently because I only have vi and git, no test environment

@pedrobaeza
Copy link
Member

Thanks 👍

Now I would ask you to squash all commits in one to also avoid noise on commit history

@hbrunn
Copy link
Member Author

hbrunn commented Aug 31, 2015

and right you'd be

@mistotebe
Copy link

This is working for us as well.

@pedrobaeza
Copy link
Member

Merging then

pedrobaeza added a commit that referenced this pull request Sep 11, 2015
@pedrobaeza pedrobaeza merged commit daac236 into OCA:8.0 Sep 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants