-
-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] support qweb reports #22
Conversation
Usage | ||
===== | ||
|
||
To use this module, you need to: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this sentence. It's intended as template to explain the usage, not as an introduction to the "Try me on runbot" button
There's a linter error:
|
@@ -8,12 +8,6 @@ Configuration | |||
|
|||
To configure this module, open the report whose filename you want to change and fill in the `Download filename` field. This field is evaluated as jinja2 template with `objects` being a list of browse records of the records to print, and `o` the first record. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you take the occasion to put here an example of a simple jinja2 example (for instance ${o.name + '_report'}
)?
Tested on runbot and functionally working. |
@pedrobaeza thanks, all done |
from openerp.addons.email_template import email_template | ||
|
||
|
||
class ReportController(addons.report.controllers.main.ReportController): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an error on Travis. Maybe addons is twice imported? Use FQN to see
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pedrobaeza thanks and sorry for the noise, I'm flying blindy currently because I only have vi and git, no test environment
Thanks 👍 Now I would ask you to squash all commits in one to also avoid noise on commit history |
c282990
to
2d5d780
Compare
and right you'd be |
This is working for us as well. |
Merging then |
No description provided.