Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG] kpi #267

Merged
merged 15 commits into from
Sep 2, 2019
Merged

[12.0][MIG] kpi #267

merged 15 commits into from
Sep 2, 2019

Conversation

AdriaGForgeFlow
Copy link
Contributor

Migration of module kpi to v12.

Moved from OCA/server-tools

@pedrobaeza pedrobaeza added this to the 12.0 milestone Jan 2, 2019
@AdriaGForgeFlow AdriaGForgeFlow mentioned this pull request Jan 2, 2019
Closed
max3903
max3903 approved these changes Jan 2, 2019
View reviewed changes
Copy link
Sponsor Member

@max3903 max3903 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No test.

jarroyomorales
jarroyomorales approved these changes Aug 26, 2019
View reviewed changes
Copy link

@jarroyomorales jarroyomorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexey-pelykh
Copy link

@ageficent please tidy up the commit history

naousse and others added 14 commits September 2, 2019 12:24
@naousse @AdriaGForgeFlow
mgmtsystem_kpi rename to kpi (OCA#543)
fc16283 
* kpi migration to odoo 9
* UI error connected
* Correction base on last maxime review
* correction on @elicoidal review
* Warning exception improve in kpi_threshold
* Latest Ellicoidal comment implemented
* last Ellicoial recommendation done.
* Copyright corrected
@ivantodorovich @AdriaGForgeFlow
Increase version
46ebc0e
@ivantodorovich @AdriaGForgeFlow
Highlight invalid ranges
e8321a7
@ivantodorovich @AdriaGForgeFlow
Added myself to contributors in README
8ff2ee6
@ivantodorovich @AdriaGForgeFlow
Module upgrade is enough
4cccb42
@ivantodorovich @AdriaGForgeFlow
Add tests
9058364
@oca-travis @AdriaGForgeFlow
[UPD] Update kpi.pot
e16dbd3
@AdriaGForgeFlow
[MIG] kpi to v11
09bc908
@AdriaGForgeFlow
[UPD] Update Readme and kpi/images
76b6d7f
@etobella @AdriaGForgeFlow
[IMP] kpi: Add Kanban Views. Improve python code, Allow to access Odoo
5764f24
@JordiBForgeFlow @AdriaGForgeFlow
[kpi] allow to return kpi and color in a single call without thresholds.
e3d6f3c
@JordiBForgeFlow @AdriaGForgeFlow
add periodicity in minutes
4ba6b2e
@JordiBForgeFlow @AdriaGForgeFlow
create kpi history as sudo
a48717c
@AdriaGForgeFlow
[12.0][MIG] Migrate module kpi to v12
0bae096
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@max3903
Copy link
Sponsor Member

max3903 commented Sep 2, 2019

/ocabot merge

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Rebased to 12.0-ocabot-merge-pr-267-by-max3903-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 2, 2019
@OCA-git-bot
Merge PR #267 into 12.0
4ae4015 
Signed-off-by max3903
@OCA-git-bot OCA-git-bot merged commit bbbcb95 into OCA:12.0 Sep 2, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4ae4015. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 12.0.

@LoisRForgeFlow LoisRForgeFlow deleted the 12.0-mig-kpi branch September 3, 2019 15:28
@moylop260
Copy link

@max3903 @JordiBForgeFlow @AdriaGForgeFlow
This PR adds your dev branches to oca_dependencies

reporting-engine/oca_dependencies.txt

Lines 4 to 6 in bc2c9e9

# Until merge
server-backend-mig-dbsource-sqlite https://github.com/Eficent/server-backend 12.0-mig-base_external_dbsource_sqlite
server-backend-mig-dbsource-mysql https://github.com/Eficent/server-backend 12.0-mig-base_external_dbsource_mysql

And there is not a change to use the official OCA ones.

When we should change it?

@luisg123v
Copy link

Why those dev branches? this needs to be fixed right away!

CC @hbto @hugho-ad

@hugho-ad
Copy link

hugho-ad commented Sep 8, 2020

FYI

#432

@hbto
Copy link

hbto commented Sep 9, 2020

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexey-pelykh alexey-pelykh alexey-pelykh approved these changes

@max3903 max3903 max3903 approved these changes

@jarroyomorales jarroyomorales jarroyomorales approved these changes

Assignees

@AdriaGForgeFlow AdriaGForgeFlow

Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet