Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix issue on returning a bi_sql_view to draft and add some tests #275

Closed
wants to merge 2 commits into from

Conversation

daramousk
Copy link
Member

No description provided.

@daramousk daramousk force-pushed the 8.0-bi_sql_editor-fix branch 4 times, most recently from 9cbd701 to 697b13e Compare February 19, 2019 11:18
@daramousk
Copy link
Member Author

@hbrunn This will not turn green. Let me know what you think

@hbrunn
Copy link
Member

hbrunn commented Mar 6, 2019

the linting issues are an easy win (fix the ones for report_signer in a separate commit), and as you don't test anything after your view.unlink(), you can just as well not do it at all - a test is only a proper test if you assert something sensible about the result of the code you run.

For fixing the actual problem, you'll have to dive deep into Odoo's caching/update code, from the stack trace it looks like there are triggers generated that aren't cleaned up, you'd have to do this manually.

@daramousk
Copy link
Member Author

While the issues you mentioned have been fixed the linting issues mentioned by the runner have nothing to do with this module yet they turn the build red.

@hbrunn
Copy link
Member

hbrunn commented Jun 12, 2019

that's how it works, a build is only green if the whole repo is fine. That's why I proposed to fix them in a separate commit, that's nice for the community and increases the chances someone actually reviews and merges your PR tremendously

.travis.yml Outdated Show resolved Hide resolved
Co-Authored-By: Miquel Raïch <miquel.raich@eficent.com>
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 20, 2022
@github-actions github-actions bot closed this Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants