New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.0][MIG] report_qweb_element_page_visibility #289
[12.0][MIG] report_qweb_element_page_visibility #289
Conversation
Saran440
commented
May 24, 2019
•
edited
edited
- [BUG] : not support when print document more than 1
Hey @Saran440, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
👍 We use it in production |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (functional)
We have detected a problem related to this issue #349. Can you give it a look? |
@ioans73 yes, I found bug. But I don't know how to solve it. |
Hi, @Saran440 I've been testing and found the solution. |
@ioans73 Not work. I test function |
Hi, we have tested several cases including printing a document with a few pages, using the class |
My code is :
|
@ioans73 @kongrattapong |
This PR has the |
Hi, @Saran440 I notice you copy/paste the patch I made, whould be better if you cherry-pick my commit isn't it? |
971a811
to
c32f7a4
Compare
c32f7a4
to
c2e7352
Compare
b4d74c8
to
a03195e
Compare
@ioans73 yes, it's good idea and I fixed it. Thank you. 👍 |
/ocabot merge |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 51ae748. Thanks a lot for contributing to OCA. ❤️ |