Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG] bi_view_editor #293

Merged
merged 13 commits into from Nov 29, 2019
Merged

[12.0][MIG] bi_view_editor #293

merged 13 commits into from Nov 29, 2019

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Jun 6, 2019 •
edited

This PR is the porting of bi_view_editor to V12 with the following improvements:

  • Store the JSON data structure in ORM
  • Improved robustness
  • Fix of fields/models translation
  • Add check for consistency of groups
  • Development of new tests
  • Add LEFT JOIN capabilities
  • Add sums and avg capabilities for tree views
  • Provide graph view for table relations

@pedrobaeza pedrobaeza added this to the 12.0 milestone Jun 6, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 6, 2019
Closed
16 tasks
MiquelRForgeFlow
MiquelRForgeFlow approved these changes Jun 7, 2019
View reviewed changes
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review 👍

bi_view_editor/models/ir_model.py Outdated Show resolved Hide resolved
@astirpe astirpe force-pushed the 12_mig_bi_view_editor branch 4 times, most recently from 8ea2ba9 to e99acf4 Compare June 12, 2019 13:15
@astirpe
Copy link
Member Author

astirpe commented Jun 12, 2019

I'm adding tests but the codecov/patch is not increasing. The coverage is actually much higher, around 90%: https://codecov.io/gh/OCA/reporting-engine/tree/e99acf4ad56455afe6574307ac9712a3ed429cf6/bi_view_editor

@astirpe astirpe force-pushed the 12_mig_bi_view_editor branch 4 times, most recently from 18b24f7 to 49a2c67 Compare June 14, 2019 09:22
@astirpe
Copy link
Member Author

astirpe commented Jun 14, 2019

@pedrobaeza do you know why the codecov/patch percentage does not increase?

@astirpe astirpe force-pushed the 12_mig_bi_view_editor branch 4 times, most recently from 7f2359a to 47a07c9 Compare June 18, 2019 13:12
@bhaveshselarka
Copy link

bhaveshselarka commented Jul 2, 2019 •
edited

@astirpe @pedrobaeza @mreficent what do you think it will merge in the main branch. It's Badly required for one of project.

Thanks for this PR.

@astirpe
Copy link
Member Author

astirpe commented Jul 2, 2019

@bhaveshselarka this PR is not yet merged because of one extra review is still missing. You may want to test this PR on Runbot and report here the results. That would speed up the approval process. Thanks!

@astirpe astirpe force-pushed the 12_mig_bi_view_editor branch 2 times, most recently from 3e9ce0f to f6172a0 Compare July 11, 2019 07:34
@MiquelRForgeFlow
Copy link
Contributor

MiquelRForgeFlow commented Jul 11, 2019 •
edited

I have a tested two migrations from v11. Without last commit, no problem; with last commit, it breaks. Please, remove last commit. That monkey patch of the last commit is not obsolete.

@astirpe
Copy link
Member Author

astirpe commented Jul 11, 2019

Thank you @mreficent !

@bhaveshselarka
Copy link

@astirpe @pedrobaeza @mreficent what do you think it will merge in the main branch. It's Badly required for one of project.

Thanks for this PR.

@pedrobaeza
Copy link
Member

@bhaveshselarka why don't you review the PR, try on runbot and give your feedback for speeding up the process?

@bhaveshselarka
Copy link

Yes, @pedrobaeza I think its best idea, Let me do that stuff.

I am at currently: https://runbot.odoo-community.org/runbot/repo/github-com-oca-reporting-engine-143

Where I can find a find this PR's correct instance. Can you please help me out in that?

@pedrobaeza
Copy link
Member

On the PR itself:
Selección_008
I have launched a rebuild, as the instance has expired. Wait for the completion and you'll be able to access through the blue button. More details in https://odoo-community.org/page/review

HviorForgeFlow
HviorForgeFlow approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@HviorForgeFlow HviorForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhaveshselarka
Copy link

@pedrobaeza @hveficent @astirpe @mreficent will it merge in the main branch ?

@astirpe
Copy link
Member Author

astirpe commented Nov 26, 2019

@pedrobaeza the codecov is red but the real coverage is much higher, see also my #293 (comment). There's something wrong with codecov, so for me the actual coverage is more than acceptable.

This PR has two approvals since a long time and I don't think we will get soon any other approvals. Is it okay to merge?

@pedrobaeza
Copy link
Member

Please squash a bit the commits and I'll proceed to merge. The codecov patch is base on previous commits done, so if you have done several pushes, it can get confused by that.

astirpe and others added 13 commits November 26, 2019 12:58
@astirpe
Initial commit bi_view_editor V9
8b872e1
@astirpe
[MIG+IMP] bi_view_editor: Migration to v10 + enhancements
949b8d3 
* Add menu items creation feature
* Added selection of fields of a tree view
* Improved usability and strings made translatable
* Avoid display duplicated nodes
* Robustness
* Updated Dutch translation
* Avoid possible sql injection in bi_view_editor
* Removed deprecated RegistryManager
@oca-transbot @astirpe
OCA Transbot updated translations from Transifex
0b787fe
@tarteo @astirpe
[MIG] bi_view_editor: Migration to 11.0
decd669
@SimoRubi @astirpe
[FIX] bi_view_editor: Apostrophe + migration script
c116401 
Apostrophe in model name raised ValueError. Added needed migration script.
@astirpe
Remove logger warnings during update all
c3a37cf
@tarteo @astirpe
[FIX] Field widget, new readme + Make enabled in list view default true
f7a750a
@astirpe
Drop bi views when uninstalling module
205433a
@OCA-git-bot @astirpe
[UPD] README.rst
34231ed
@oca-travis @astirpe
[UPD] Update bi_view_editor.pot
346f840
@astirpe
[12.0][MIG] bi_view_editor
c6fca71
@astirpe
Add extra functionalities
11ec4ee 
Add LEFT JOIN capabilities

Add sums and avg capabilities for tree views

Robustness and code review

Provide ER diagram view for table relations
@astirpe
Add graphviz in .travis.yml
53f89ad
@astirpe
Copy link
Member Author

astirpe commented Nov 26, 2019

@pedrobaeza done!

@astirpe
Copy link
Member Author

astirpe commented Nov 29, 2019

@pedrobaeza would be great if we can get this PR merged. Thank you!

@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-293-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 29, 2019
@OCA-git-bot
Merge PR #293 into 12.0
d7da1ee 
Signed-off-by pedrobaeza
@OCA-git-bot OCA-git-bot merged commit 53f89ad into OCA:12.0 Nov 29, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 01c97ce. Thanks a lot for contributing to OCA. ❤️

@astirpe astirpe deleted the 12_mig_bi_view_editor branch November 30, 2019 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

@HviorForgeFlow HviorForgeFlow HviorForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@astirpe @bhaveshselarka @MiquelRForgeFlow @pedrobaeza @OCA-git-bot @HviorForgeFlow @oca-transbot @tarteo @SimoRubi @oca-travis