[10.0][FIX]date fields as date #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any opinion is welcome 🍬 |
MiquelRForgeFlow
approved these changes
Sep 23, 2019
dreispt
approved these changes
Apr 2, 2020
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
This PR has the |
|
Congratulations, your PR was merged at 69a7bea. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am having issues when querying date fields. They are converted to datetime in the views (even if I select date as field type). Consequently the timezone is applied. Consequently dates are shown in different dates.
For example: invoice date 01-01-2019 -> to datetime: 01-01-2019 00:00:00 UTC -> If I run the report in a place with timezone UTC-X I get invoice date 31-12-2018 --> Not correct.
The solution here seems not to affect datetime fileds as they are queried as timestamp without time zone. However I am not sure this works for every use case, so I'd appreciate a lot opinions of people that use this module frequently.
Thank you!