Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG] report_csv #305

Merged
merged 6 commits into from
Nov 22, 2019
Merged

[12.0][MIG] report_csv #305

merged 6 commits into from
Nov 22, 2019

Conversation

jarroyomorales
Copy link

Standard migration

@etobella

etobella
etobella approved these changes Aug 2, 2019
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just some minor comments

report_csv/report/report_csv.py Outdated Show resolved Hide resolved
report_csv/readme/CONTRIBUTORS.rst Show resolved Hide resolved
@jarroyomorales
Copy link
Author

jarroyomorales commented Aug 2, 2019 •
edited
Loading

@etobella Comments attended!

LoisRForgeFlow
LoisRForgeFlow requested changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested on runbot and locally and it is printing nothing for me.
Peek 2019-10-29 12-48

@etobella etobella mentioned this pull request Nov 8, 2019
Closed
@jarroyomorales
Copy link
Author

@lreficent Fixed! Sorry for the late reply, I didnt see the comment 😅

LoisRForgeFlow
LoisRForgeFlow approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works good now. A small comment inline.

Thanks! 👍

report_csv/models/ir_report.py Outdated Show resolved Hide resolved
report_csv/models/ir_report.py Outdated Show resolved Hide resolved
@JordiBForgeFlow
Copy link
Sponsor Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-305-by-jbeficent-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 22, 2019
@OCA-git-bot
Merge PR #305 into 12.0
12e7761 
Signed-off-by jbeficent
@OCA-git-bot OCA-git-bot merged commit 8dc0ebf into OCA:12.0 Nov 22, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 516a79e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordiBForgeFlow JordiBForgeFlow JordiBForgeFlow approved these changes

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

@etobella etobella etobella approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jarroyomorales @JordiBForgeFlow @OCA-git-bot @LoisRForgeFlow @etobella @oca-travis