[11.0][IMP] report_xlsx, make sure print_report_name works #327
Conversation
kittiu
force-pushed
the
11.0-imp-report_xlsx-print_report_name
branch
from
94dd6ad
to
ec6adb0
Compare
report_xlsx/controllers/main.py
Outdated
| @@ -29,13 +31,18 @@ def report_routes(self, reportname, docids=None, converter=None, **data): | |||
| xlsx = report.with_context(context).render_xlsx( | |||
| docids, data=data | |||
| )[0] | |||
| report_name = report.report_file | |||
| if report.print_report_name and not len(docids) > 1: | |||
There was a problem hiding this comment.
Here you should check that docids is set:
if report.print_report_name and docids and not len(docids) > 1:
Just realized that sometimes a report is launched without docids, and it will fail.
In that case is fair to not personalize the name because a main object is not given and the data property would contain the details for rendering the report.
There was a problem hiding this comment.
Thank you for noticing. I fixed per your request here and also in v12
kittiu
force-pushed
the
11.0-imp-report_xlsx-print_report_name
branch
from
ec6adb0
to
9549996
Compare
|
/ocabot merge patch |
|
Is this needed for 12.0? |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
It seems that in v12 is already: |
|
@pedrobaeza |
|
Ok, thanks for confirming |
|
Congratulations, your PR was merged at 42bb138. Thanks a lot for contributing to OCA. ❤️ |
@jffernandez would you help test again? :)