Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] report xlsx migration to v13 #331

Merged
merged 24 commits into from Jan 8, 2020
Merged

[13.0][MIG] report xlsx migration to v13 #331

merged 24 commits into from Jan 8, 2020

Conversation

schout-it
Copy link
Contributor

No description provided.

@pedrobaeza pedrobaeza added this to the 13.0 milestone Oct 1, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 1, 2019
Closed
13 tasks
@etobella
Copy link
Member

etobella commented Oct 1, 2019

I have tried to make it work on runbot, but it leaves some JS errors

@dynapps
Copy link

dynapps commented Oct 2, 2019

@etobella could you tell me where?
if I try the runbot, go to partners, select list view and click the export all (download icon)
it seems to work without problem.
This is for the v13
In this migration I included a javascript fix that should probably be backported to v12

@sbidoul
Copy link
Member

sbidoul commented Oct 21, 2019 •
edited

@schout-it could you rebase to get the new linters, and apply pre-commit run -a in a separate commit?

adrienpeiffer and others added 22 commits October 22, 2019 09:35
@adrienpeiffer @schout-it
[CHG] Rename base_report_xlsx to report_xlsx and add xlsx report type…
fb8015d 
… in selection
@sebalix @schout-it
[IMP] report_xlsx - Pass the report instance as well as ids of record…
5e20786 
…s to print to the 'create_xlsx_report' method + Instanciate the parser and make it available for the 'generate_xlsx_report' method
@adrienpeiffer @schout-it
[MIG] Migration of report_xlsx to 10.0 (OCA#76)
b5733e1
@sbidoul @schout-it
[10.0] report_xlsx: Allow to define options for workbook creation (OC…
6340e0f 
…A#98)

* Allow to define options for workbook creation
@oca-transbot @schout-it
OCA Transbot updated translations from Transifex
89841a0
@etobella @schout-it
[MIG] report_xlsx: Migration to 11.0
037e818
@oca-transbot @schout-it
OCA Transbot updated translations from Transifex
21cd5b3
@naglis @schout-it
[IMP] report_fillpdf, report_xlsx, report_xml: Use content_dispositio…
14fd332 
…n helper
@oca-travis @schout-it
[UPD] Update report_xlsx.pot
3be9b28
@gdgellatly @schout-it
Fix report_xlsx for printing from wizards
e9ac28b
@ovnicraft @schout-it
[MIG] report_xlsx: Migration to 12.0
102637c 
* refactor: On new ActionManager override _makeReportUrls and triggerDownload to support XLSX format
* pass action to custom _downloadReportXLSX: Need action to get report data
* dict constructor to remove context lang
@pedrobaeza @schout-it
[IMP] report_xlsx: README by fragments
54abfc7
@oca-travis @schout-it
[UPD] Update report_xlsx.pot
f43ca37
@oca-transbot @schout-it
Update translation files
4f221cd 
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
@rschnapka @schout-it
Translated using Weblate (German)
9f29cc7 
Currently translated at 88.2% (15 of 17 strings)

Translation: reporting-engine-12.0/reporting-engine-12.0-report_xlsx
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-report_xlsx/de/
@OCA-git-bot @schout-it
[UPD] README.rst
6b06885
@kittiu @schout-it
[12.0][IMP] report_xlsx, make sure print_report_name works
b0f93f4
@pedrocasi @schout-it
Added translation using Weblate (Portuguese)
a7ffccd
@pedrocasi @schout-it
Translated using Weblate (Portuguese)
d7b3569 
Currently translated at 94.4% (17 of 18 strings)

Translation: reporting-engine-12.0/reporting-engine-12.0-report_xlsx
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-report_xlsx/pt/
@OCA-git-bot @schout-it
report_xlsx 12.0.1.0.1
a196778
@schout-it
[MIG] report_xlsx: Migration to 13.0
cf92447
@schout-it
[MIG][IMP][13.0] rebase to include new linters
aeff99f
@kongrattapong
Copy link
Contributor

It's seem it's still not working.
I go to partner then "Print to XLSX" but it's not export .xlsx file
xlsx_report

@JoanSForgeFlow
Copy link
Contributor

Please, if possible, review my PR (schout/reporting-engine) that fixes the module.

@schout-it
Copy link
Contributor Author

Done

AdriaGForgeFlow
AdriaGForgeFlow approved these changes Dec 24, 2019
View reviewed changes
Copy link
Contributor

@AdriaGForgeFlow AdriaGForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review 👍

@JoanSForgeFlow
Copy link
Contributor

Thank you @schout-it !

@JoanSForgeFlow JoanSForgeFlow mentioned this pull request Jan 7, 2020
Merged
JoanSForgeFlow
JoanSForgeFlow approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@JoanSForgeFlow JoanSForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@bhaveshselarka bhaveshselarka mentioned this pull request Jan 8, 2020
Closed
@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-331-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 8, 2020
@OCA-git-bot
Merge PR #331 into 13.0
1973af6 
Signed-off-by pedrobaeza
@OCA-git-bot OCA-git-bot merged commit d04536e into OCA:13.0 Jan 8, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ce85964. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdriaGForgeFlow AdriaGForgeFlow AdriaGForgeFlow approved these changes

@JoanSForgeFlow JoanSForgeFlow JoanSForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration ready to merge
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.

None yet