Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0][ADD] Batch report printing #334

Closed
wants to merge 1 commit into from
Closed

[11.0][ADD] Batch report printing #334

wants to merge 1 commit into from

Conversation

bodedra
Copy link
Member

@bodedra bodedra commented Oct 17, 2019 •
edited

This module will allow to print multiple QWeb reports in a single batch.

For example, picking, packing, reports needs to be printed together
in a single batch.

CC @max3903

@bodedra bodedra force-pushed the bodedra_report_batch branch 2 times, most recently from 60a1ddd to 4a07f14 Compare October 17, 2019 13:48
@dreispt dreispt self-requested a review October 18, 2019 18:11
@dreispt dreispt added this to the 11.0 milestone Oct 18, 2019
@bodedra
Copy link
Member Author

bodedra commented Oct 24, 2019

Ping @max3903 @osi-scampbell @osimallen

dreispt
dreispt approved these changes Nov 8, 2019
View reviewed changes
Copy link
Sponsor Member

@dreispt dreispt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Added non-blocking suggestions.

report_batch/models/ir_action_report.py Show resolved Hide resolved
report_batch/models/ir_action_report.py Show resolved Hide resolved
report_batch/models/ir_action_report.py Show resolved Hide resolved
report_batch/models/ir_action_report.py Outdated Show resolved Hide resolved
report_batch/models/ir_action_report.py Show resolved Hide resolved
@dreispt dreispt mentioned this pull request Nov 10, 2019
Closed
@dreispt dreispt requested a review from max3903 November 11, 2019 08:56
@bodedra
Copy link
Member Author

bodedra commented Nov 27, 2019

Ping @max3903

@dreispt
Copy link
Sponsor Member

dreispt commented Mar 23, 2020

I' would like to merge this one. Anyone opposing?
Thanks!

@kittiu
Copy link
Member

kittiu commented Mar 24, 2020

Interesting module +1

@bodedra
Copy link
Member Author

bodedra commented Apr 1, 2020

are we good to merge this?

@dreispt
Copy link
Sponsor Member

dreispt commented Apr 1, 2020

/ocabot merge

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 11.0-ocabot-merge-pr-334-by-dreispt-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 1, 2020
@OCA-git-bot
Merge PR #334 into 11.0
6a7764c 
Signed-off-by dreispt
@bodedra
Copy link
Member Author

bodedra commented Apr 8, 2020

Is something stuck in this PR?

@dreispt
Copy link
Sponsor Member

dreispt commented Apr 9, 2020

/ocabot merge

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 11.0-ocabot-merge-pr-334-by-dreispt-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 9, 2020
@OCA-git-bot
Merge PR #334 into 11.0
d268169 
Signed-off-by dreispt
@bodedra
Copy link
Member Author

bodedra commented Apr 9, 2020 •
edited

auth_oauth_environment and server_environment modules create trouble to merge it.

Firefox_Screenshot_2020-04-09T17-07-24 995Z

Also report_qr module.

Firefox_Screenshot_2020-04-09T17-14-12 429Z

@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 11.0-ocabot-merge-pr-334-by-dreispt-bump-no.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@dreispt
Copy link
Sponsor Member

dreispt commented Apr 9, 2020

Add this to .travis.yml: https://github.com/OCA/server-env/blob/13.0/.travis.yml#L45

@bodedra bodedra mentioned this pull request Apr 10, 2020
Closed
@bodedra
Copy link
Member Author

bodedra commented Apr 10, 2020

@dreispt Would you please try to merge it again?

@dreispt
Copy link
Sponsor Member

dreispt commented Apr 11, 2020

/ocabot merge

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 11.0-ocabot-merge-pr-334-by-dreispt-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 11, 2020
@OCA-git-bot
Merge PR #334 into 11.0
01d5bd3 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 11.0-ocabot-merge-pr-334-by-dreispt-bump-no.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@bodedra
Copy link
Member Author

bodedra commented Apr 13, 2020 •
edited

@dreispt 11.0 branch has issue with running_env which is fixed on 13.0. So instead of wait/fix in 11.0, can we merge 13.0 for this module. PR reference: #386

@dreispt
Copy link
Sponsor Member

dreispt commented Apr 22, 2020

The server_environment issue was fixed.
Restarting the Travis build to confirm.

@github-actions
Copy link

github-actions bot commented May 8, 2022

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 8, 2022
@github-actions github-actions bot closed this Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreispt dreispt dreispt approved these changes

@max3903 max3903 Awaiting requested review from max3903

Assignees
No one assigned
Labels
needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bodedra @dreispt @kittiu @OCA-git-bot