Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0] report_py3o, report_py3o_fusion_server: Migration to 13.0 #347

Merged
merged 109 commits into from
Jun 18, 2020
Merged

[13.0] report_py3o, report_py3o_fusion_server: Migration to 13.0 #347

merged 109 commits into from
Jun 18, 2020

Conversation

lmignon
Copy link
Sponsor Contributor

@lmignon lmignon commented Nov 19, 2019 •
edited
Loading

supersedes #339

lmignon and others added 30 commits November 19, 2019 14:23
@lmignon
Move to report_py3o after import from HG
61ed3c8
@lmignon
Add setup
2f29bec
@lmignon
[FIX] View inheritance may not use attribute 'string' as a selector.
40f4dd8
@lmignon
[IMP] New API + Short Hearder
8ae3b02
@lmignon
Remove unicode string
67b54ae
@lmignon
[IMP] Add the possiblity to get the template from an absolute path on…
21c939e 
… the server
@lmignon
[IMP] Allow user to use local fusion
980ca9c
@lmignon
Add a simple way to extend the parser context
6084307
@lmignon
Remove ACL on removed model
1fd98bc
@lmignon
Improve filetype selection name
35b4394
@lmignon
Fix native flag
7b37a5c
@faide @lmignon
fixed missing comma in model definition
e895553
@lmignon
Add simple tests and fix call to fusion server
22bff73
@lmignon
Fix skip fusion on server when the fusion is local
2d99e76
@lmignon
Improve tests
ef81ba2
@lmignon
Replace openerp element by odoo
0686c3c
@alexis-via @lmignon
Small usability improvements
d5ce224 
Replace README.md by README.rst (not finished)
@alexis-via @lmignon
Take into accounts most remarks of @lasley
15a8a2e 
Remove <data> in views
Protect import of py3o libs
Remove dep on base module
Other small changes
@lmignon
Replace plain SQL by orm
fd36ac1
@lmignon
rename module ir_report to ir_actions_report_xml
5017b75
@lmignon
Add more tests and fixes issues found by tests
d8d652e
@lmignon
[FIX] Check constrains only if report_type == 'py3o'
f9d3aa6
@alexis-via @lmignon
report_py3o: full installation procedure in README
4bc3b57
@alexis-via @lmignon
Port report_py3o to Odoo v10
ebe80d5
@alexis-via @lmignon
Update version numbers
4dfdcfd 
Rename __openerp__.py to __manifest__.py
@alexis-via @lmignon
PEP8 fix
4636bd3
@alexis-via @lmignon
Update README
9ed3231
@alexis-via @lmignon
FIX double dot in filename
df0c5b0
@alexis-via @lmignon
Add access to report_xml object in report
7e6a885
@alexis-via @lmignon
FIX Adapt test suite to my recent commit to avoid double dot on filen…
36a3e8b 
…ame extension
njeudy
njeudy suggested changes Jan 7, 2020
View reviewed changes
Copy link

@njeudy njeudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Ok for me code and test

Just some readme typo.

report_py3o/README.rst Show resolved Hide resolved
report_py3o/README.rst Show resolved Hide resolved
report_py3o/README.rst Show resolved Hide resolved
@lmignon
Copy link
Sponsor Contributor Author

lmignon commented Jan 7, 2020

@njeudy The readme file file is generated by oca-gen-addon-readme and will be regenerated by the bot when merging....

@sbejaoui @lmignon
[12.0][FIX] - report_py3o: run libreoffice in an isolated user instal…
2885688 
…lation

Bug when more than one conversion print is launched within the same libreoffice instance.

The standard behavior of libreoffice when a user open it while another instance is
running is to show a new window and throw an error if a new instance is forced within
the same user installation [see](https://bugs.documentfoundation.org/show_bug.cgi?id=37531).

This implies a bug in report_py3o module when we call libreoffice at the same time for
different documents.

To reproduce this bug:

**Case 1:**
1.  Simultaneously print two documents.

**Case 2:**
1.  Run print jobs using job_queue module
2.  Manually print another document

**Case 3:**
2.  Open libreoffice
3.  Print a py3o report

This PR creates a temporary user installation for each libreoffice conversion to bypass this limitation.
@sudo-san
Copy link

Is there an approximate date when report_py3o will be available for the V13?

Thank you for a short feedback.

@lmignon
Copy link
Sponsor Contributor Author

lmignon commented Mar 20, 2020

@sudo-san These addons are already migrated by reviews are required to get these merged

@sudo-san
Copy link

@lmignon Thanks a lot for you quick reply. Is there already a way to download the current version for odoo 13?

@lmignon
Copy link
Sponsor Contributor Author

lmignon commented Mar 23, 2020

@lmignon Thanks a lot for you quick reply. Is there already a way to download the current version for odoo 13?

from the submitted branch. https://github.com/acsone/reporting-engine/tree/13.0-mig-report_py3o

@njeudy
Copy link

njeudy commented May 12, 2020

@lmignon any way to make it merged ? I use this branch on my V13 deployments ..

@lmignon
Copy link
Sponsor Contributor Author

lmignon commented May 12, 2020

@njeudy Before the end of my wok and now some pre-commit hooks were added. After some tests, I'm not able to find a way to fix the code and have pre-commit happy....

tonygalmiche
tonygalmiche approved these changes May 19, 2020
View reviewed changes
Copy link
Sponsor

@tonygalmiche tonygalmiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on my computer
Everything works as expected
Thank you for this migration

@lmignon
Copy link
Sponsor Contributor Author

lmignon commented May 19, 2020

All the tests works on my computer and I don't see what's wrong with travis.... We also use successfully these addons into production.

@dreispt
Copy link
Sponsor Member

dreispt commented Jun 17, 2020

@lmignon TravicCI log shows one test failing. I can try a merge and see it we get a different result.

@dreispt
Copy link
Sponsor Member

dreispt commented Jun 17, 2020

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-347-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8110770 into OCA:13.0 Jun 18, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 87f7e76. Thanks a lot for contributing to OCA. ❤️

@lmignon lmignon deleted the 13.0-mig-report_py3o branch June 18, 2020 07:13
@lmignon
Copy link
Sponsor Contributor Author

lmignon commented Jun 18, 2020

Thak you @dreispt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonygalmiche tonygalmiche tonygalmiche approved these changes

@njeudy njeudy njeudy approved these changes

@ThomasBinsfeld ThomasBinsfeld ThomasBinsfeld approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet