-
-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0][ENH] sql view - allow group operator #351
[11.0][ENH] sql view - allow group operator #351
Conversation
Replaces OCA#344 Adds the possibility, for float and integer columns, to apply a group operator (average, min, max).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Functional review.
@CasVissers Do you know what we need to do to get this merged? |
@legalsylvain Think this one is also ready to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge
This PR has the |
/ocabot merge |
This PR looks fantastic, let's merge it! |
@legalsylvain your merge command was aborted due to failed check(s), which you can inspect on this commit of 11.0-ocabot-merge-pr-351-by-legalsylvain-bump-no. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
@legalsylvain :( I don't understand the error - my expertise is not that great. It appears to be a test unrelated to my changes !? |
Hi @richard-willdooit : I have no idea. |
/ocabot merge |
What a great day to merge this nice PR. Let's do it! |
@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 11.0-ocabot-merge-pr-351-by-dreispt-bump-no. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
The |
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 7a09e28. Thanks a lot for contributing to OCA. ❤️ |
Replaces #344
Adds the possibility, for float and integer columns, to
apply a group operator (average, min, max).