Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0][ENH] sql view - allow group operator #351

Merged
merged 4 commits into from
Jun 17, 2020

Conversation

richard-willdooit
Copy link

Replaces #344

Adds the possibility, for float and integer columns, to
apply a group operator (average, min, max).

Replaces OCA#344

Adds the possibility, for float and integer columns, to
apply a group operator (average, min, max).
Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Functional review.

@richard-willdooit
Copy link
Author

@CasVissers Do you know what we need to do to get this merged?

@CasVissers-360ERP
Copy link

@legalsylvain Think this one is also ready to merge?

Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@legalsylvain
Copy link
Contributor

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 11.0-ocabot-merge-pr-351-by-legalsylvain-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 13, 2020
Signed-off-by legalsylvain
@OCA-git-bot
Copy link
Contributor

@legalsylvain your merge command was aborted due to failed check(s), which you can inspect on this commit of 11.0-ocabot-merge-pr-351-by-legalsylvain-bump-no.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@richard-willdooit
Copy link
Author

@legalsylvain :( I don't understand the error - my expertise is not that great. It appears to be a test unrelated to my changes !?

@legalsylvain
Copy link
Contributor

Hi @richard-willdooit : I have no idea.
could you try to rebase your PR ?

@dreispt
Copy link
Sponsor Member

dreispt commented Apr 2, 2020

/ocabot merge

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 11.0-ocabot-merge-pr-351-by-dreispt-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 2, 2020
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 11.0-ocabot-merge-pr-351-by-dreispt-bump-no.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@dreispt
Copy link
Sponsor Member

dreispt commented Apr 4, 2020

The report_qr tests are failing.
I created issue #383 for this.

@dreispt
Copy link
Sponsor Member

dreispt commented Jun 17, 2020

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 11.0-ocabot-merge-pr-351-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 43db140 into OCA:11.0 Jun 17, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7a09e28. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants