Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Refer to safe_eval method, not module #357

Merged
merged 1 commit into from Apr 2, 2020
Merged

[FIX] Refer to safe_eval method, not module #357

merged 1 commit into from Apr 2, 2020

Conversation

StefanRijnhart
Copy link
Member

Fixes

report_qweb_pdf_watermark/models/report.py", line 40, in get_pdf
    dict(env=self.env, docs=self.env[report.model].browse(docids)),
TypeError: 'module' object is not callable

@StefanRijnhart StefanRijnhart added this to the 10.0 milestone Dec 18, 2019
@StefanRijnhart
[FIX] Refer to safe_eval method, not module
cd016c9 
Fixes
```
report_qweb_pdf_watermark/models/report.py", line 40, in get_pdf
    dict(env=self.env, docs=self.env[report.model].browse(docids)),
TypeError: 'module' object is not callable
```
@StefanRijnhart StefanRijnhart force-pushed the fix/10.0/report_qweb_pdf_watermark/safe_eval_reference branch from ce13bcf to cd016c9 Compare December 18, 2019 08:30
gdgellatly
gdgellatly approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@gdgellatly gdgellatly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dreispt
Copy link
Sponsor Member

dreispt commented Apr 2, 2020

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 10.0-ocabot-merge-pr-357-by-dreispt-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 2, 2020
@OCA-git-bot
Merge PR #357 into 10.0
a32a73b 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

It looks like something changed on 10.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 10.0-ocabot-merge-pr-357-by-dreispt-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c3c1081 into OCA:10.0 Apr 2, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f28f9a0. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreispt dreispt dreispt approved these changes

@gdgellatly gdgellatly gdgellatly approved these changes

@hbrunn hbrunn Awaiting requested review from hbrunn

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@StefanRijnhart @dreispt @OCA-git-bot @gdgellatly