-
-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] [13.0] report_xml: Migrate to version 13.0 #359
Conversation
Hey @Tatider, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
Linter failed, but I don't agree with suggested changes by next reasons:
I can make them as a separate commit which message will clear describe, that these are black required changes. But I really would like discuss them with someone. They don't look like good changes for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments about what you made...
I think it is a good idea to add the schema, but I do not agree with the implementation.
c128fbf
to
68ecb79
Compare
I understand your concerns, but OCA decided to use black in order to make cleaner code. I think you should follow the standard usage, and include this on your commit, as this is part of the standard now. |
bd7486c
to
4263985
Compare
Yes, I understand that it's a part of a standard now, but if the main purpose of using black is make code cleaner, but it doesn't even follow the PEP8... So:
And now linters are fine, but build failed. I don't think my changes cause this problem ( |
Travis is green, some error was raised on OCB, but it has been fixed now. |
b21fd68
to
f883ac2
Compare
f883ac2
to
e8a676b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM only non-blocking comments.
de82bae
to
98e36f4
Compare
18d498d
to
cf3c261
Compare
@etobella please validate the PR and do you agree with the new authorship? |
Any progress here? |
@Tatider CAn you do a rebase to fix isort conficts?? Thanks |
Almost any XML must start with this. Let's make it easier.
Previous instructions were misleading
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-12.0/reporting-engine-12.0-report_xml Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-report_xml/
cf3c261
to
7f8b3c4
Compare
Done |
785ff04
to
dc86d22
Compare
dc86d22
to
a78247d
Compare
This PR need reviews |
This PR has the |
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at f96fea4. Thanks a lot for contributing to OCA. ❤️ |
against XSD Schema