[FIX] [report_xls] Override the field to add the value instead of breaking the validation system #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garamotte
changed the title
|
👍, thanks! |
|
Thanks @sylvain-garancher - Can you please rebase & fix the conflicts? |
Garamotte
force-pushed
the
8.0-fix-report_type_field
branch
from
8096434
to
1dbbbc5
Compare
Garamotte
force-pushed
the
8.0-fix-report_type_field
branch
from
1dbbbc5
to
63e99ca
Compare
|
Rebase done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is better to override the field in the new API way, to really add a possible value in the selection, instead of "breaking" the fields's value validation system.
This also allows Odoo to display the "XLS" value in the reports list, instead of "unknown".