[FIX] Cursor of browsed objects is already closed when fetching downl…

[StefanRijnhart]

…oad filename

Fixes #30

[StefanRijnhart]

Delegating the fetching of the download filename to the xml report model. In the original version, the fetching was depending on records browsed in the controller, but the cursor of the browse records would be closed after the call from the controller. cc @sebastienbeau as you backported this module to 7.0.

[paulius-sladkevicius]

@StefanRijnhart I suggest to merge it, it works fine on my side with this fix. Took to much time to figure out why it don't work, but finally came idea to check PR's, thanks!

[pedrobaeza]

It's needed to fix pylint errors first:

report_custom_filename/model/ir_actions_report_xml.py:50:17: E122 continuation line missing indentation or outdented
report_custom_filename/model/ir_actions_report_xml.py:51:17: E122 continuation line missing indentation or outdented
report_custom_filename/model/ir_actions_report_xml.py:52:17: E122 continuation line missing indentation or outdented
report_custom_filename/model/ir_actions_report_xml.py:53:13: E122 continuation line missing indentation or outdented

[coveralls]

Coverage increased (+0.2%) to 30.62% when pulling 1f21d20 on StefanRijnhart:7.0-report_custom_filename_closed_cursor into 008f678 on OCA:7.0.

[StefanRijnhart]

@komsas good! @pedrobaeza thanks for pointing that out. Flakey eightie now has a blanket and nice warm cup of milk.

[pedrobaeza]

👍