Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] report_py3o: Migration to 14.0 #445

Merged
merged 111 commits into from
Dec 9, 2021
Merged

[14.0][MIG] report_py3o: Migration to 14.0 #445

merged 111 commits into from
Dec 9, 2021

Conversation

elmeriniemela
Copy link
Contributor

No description provided.

@rvalyi
Copy link
Member

rvalyi commented Oct 21, 2020

Thank you for the work @elmeriniemela , but please enforce the standard migration process here https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-14.0 (that is mostly preserve the commit history). Please redo the pull request in the proper way, then we will be happy to review.

lmignon and others added 29 commits October 21, 2020 19:13
@lmignon @elmeriniemela
Move to report_py3o after import from HG
75ab2d3
@lmignon @elmeriniemela
Add setup
aa3d383
@lmignon @elmeriniemela
[FIX] View inheritance may not use attribute 'string' as a selector.
b346ff0
@lmignon @elmeriniemela
[IMP] New API + Short Hearder
a88aa63
@lmignon @elmeriniemela
Remove unicode string
982fff8
@lmignon @elmeriniemela
[IMP] Add the possiblity to get the template from an absolute path on…
6d4efe1 
… the server
@lmignon @elmeriniemela
[IMP] Allow user to use local fusion
10ce6f6
@lmignon @elmeriniemela
Add a simple way to extend the parser context
34282d9
@lmignon @elmeriniemela
Remove ACL on removed model
e546dd1
@lmignon @elmeriniemela
Improve filetype selection name
1f81e4c
@lmignon @elmeriniemela
Fix native flag
7eebf67
@faide @elmeriniemela
fixed missing comma in model definition
61172a4
@lmignon @elmeriniemela
Add simple tests and fix call to fusion server
94df910
@lmignon @elmeriniemela
Fix skip fusion on server when the fusion is local
7285c99
@lmignon @elmeriniemela
Improve tests
bac8750
@lmignon @elmeriniemela
Replace openerp element by odoo
67d5ac0
@alexis-via @elmeriniemela
Small usability improvements
46f901b 
Replace README.md by README.rst (not finished)
@alexis-via @elmeriniemela
Take into accounts most remarks of @lasley
c3f8e1c 
Remove <data> in views
Protect import of py3o libs
Remove dep on base module
Other small changes
@lmignon @elmeriniemela
Replace plain SQL by orm
6201dc9
@lmignon @elmeriniemela
rename module ir_report to ir_actions_report_xml
8c279ca
@lmignon @elmeriniemela
Add more tests and fixes issues found by tests
ac39d06
@lmignon @elmeriniemela
[FIX] Check constrains only if report_type == 'py3o'
0b2d58a
@alexis-via @elmeriniemela
report_py3o: full installation procedure in README
cc4ef3d
@alexis-via @elmeriniemela
Port report_py3o to Odoo v10
9c30326
@alexis-via @elmeriniemela
Update version numbers
726d7cf 
Rename __openerp__.py to __manifest__.py
@alexis-via @elmeriniemela
PEP8 fix
34c554e
@alexis-via @elmeriniemela
Update README
afc389b
@alexis-via @elmeriniemela
FIX double dot in filename
1203c24
@alexis-via @elmeriniemela
Add access to report_xml object in report
a6b5b2a
@elmeriniemela
Copy link
Contributor Author

@alexis-via I applied your patch. (just plain git apply and commit, I didnt test it myself)

@nilshamerlinck
Copy link
Contributor

Hi @elmeriniemela applying the suggested changes + running pre-commit run -a will make both checks green :)

elmeriniemela and others added 3 commits November 7, 2021 14:00
@elmeriniemela @nilshamerlinck
[IMP] Workaround for genshi DeprecationWarning that makes runbot buil…
779da4f 
…d red

Co-authored-by: Nils Hamerlinck <nilshamerlinck@users.noreply.github.com>
@elmeriniemela @nilshamerlinck
[IMP] Cleanup unnecessary imports
6760507 
Co-authored-by: Nils Hamerlinck <nilshamerlinck@users.noreply.github.com>
@elmeriniemela @nilshamerlinck
[IMP] Remove except of IOError as its an alias to OSError in python3
0ddf462 
Co-authored-by: Nils Hamerlinck <nilshamerlinck@users.noreply.github.com>
@lmignon
Copy link
Sponsor Contributor

lmignon commented Nov 9, 2021

@elmeriniemela Thank you for all this work. Can you check the pre-commit issues https://github.com/OCA/reporting-engine/runs/4149149084?check_suite_focus=true#step:4:106 (mainly black problem).Once fixed I'll merge your PR

lmignon
lmignon requested changes Nov 9, 2021
View reviewed changes
Copy link
Sponsor Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-commit issues to fix. Otherwise LGTM (code review only)

@leemannd
Copy link
Contributor

Hello @elmeriniemela you can fix your PR by running pre-commit run -a or either merge the PR I did against your branch elmeriniemela#1

@leemannd
Copy link
Contributor

@OCA/reporting-engine-maintainers Ready to be merged :)

@leemannd
Copy link
Contributor

leemannd commented Dec 6, 2021

Travis is failing because it is trying to fetch a closed PR with the same code. I'm not sure why it does so.

@nilshamerlinck
Copy link
Contributor

Looks like a bug on travis side indeed. Given that the travis build was green before and pre-commit cleaning has now been done, I think this can be merged as is @lmignon @alexis-via :)

@lmignon
Copy link
Sponsor Contributor

lmignon commented Dec 9, 2021

@nilshamerlinck Thank you for all your work. I've restarted travis jobs. We need to have travis 🟢 to be able to merge.

@lmignon
Copy link
Sponsor Contributor

lmignon commented Dec 9, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-445-by-lmignon-bump-nobump, awaiting test results.

@lmignon
Copy link
Sponsor Contributor

lmignon commented Dec 9, 2021

Strange... For travis, this pr seems to be linked to #551

@OCA-git-bot OCA-git-bot merged commit 5ed0c54 into OCA:14.0 Dec 9, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4c1b803. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilshamerlinck nilshamerlinck nilshamerlinck left review comments

@mourad-ehm mourad-ehm mourad-ehm requested changes

@lmignon lmignon lmignon approved these changes

@njeudy njeudy njeudy approved these changes

@alexis-via alexis-via alexis-via approved these changes

@leemannd leemannd leemannd approved these changes

@hparfr hparfr hparfr approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet