9.0 Migrate report_custom_filename #52
Conversation
| 'object': objects[:1], | ||
| 'ext': report.report_type.replace('qweb-', ''), | ||
| }) | ||
| generated_filename = eval(report.download_filename, {'object': objects, 'time': time}) |
There was a problem hiding this comment.
You should use from openerp.tools.safe_eval import safe_eval instead of eval.
sla-subteno-it
force-pushed
the
9.0-migrate-report_custom_filename
branch
from
58aa429
to
43ba075
Compare
|
Your migration is ripping out the basic things of the module, so the fail in Travis is expected. Are you sure this is working? |
…lename like attachement
sla-subteno-it
force-pushed
the
9.0-migrate-report_custom_filename
branch
from
43ba075
to
db108e4
Compare
|
👍 I've tested this PR and seems to work fine, at least for the regular use case (document → print). Not sure if the removed controller is needed for some other use case, but Travis seems to be fine now. |
| 'object': objects[:1], | ||
| 'ext': report.report_type.replace('qweb-', ''), | ||
| }) | ||
| generated_filename = safe_eval(report.download_filename, |
There was a problem hiding this comment.
safe_eval uses Python syntax, not Jinja2 syntax, so it changes from the way Odoo parses this in the attachments.
|
any updates ? |
|
Closing as there's no answer. |
Hello,
I migrated report_custom_filename in v9 but I used the same format of attachement field instead of mako template.