Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX][report_xls] Add a variable when import fails. #67

Merged
merged 1 commit into from
Aug 17, 2016

Conversation

yajo
Copy link
Member

@yajo yajo commented Aug 17, 2016

Otherwise you can get errors like:

    from . import reporting_xls
  File "/opt/odoo/available/OCA/l10n-spain/account_balance_reporting_xls/report/reporting_xls.py", line#
Please enter the commit message for your changes. Lines starting
 31, in <module># with '#' will be ignored, and an empty message aborts the commit.
    from openerp.addons.report_xls.report_xls import report_xls# On branch 8.0-report_xls-protected_import
  File "/opt/odoo/available/OCA/OCB/openerp/modules/module.py", line 80, in load_module# Changes to be
committed:
    mod = imp.load_module('openerp.addons.' + module_part, f, path, descr)# modified: report_xls.py
  File "/opt/odoo/available/OCA/reporting-engine/report_xls/__init__.py", line 24, in <module>#
    from . import report_xls
  File "/opt/odoo/available/OCA/reporting-engine/report_xls/report_xls.py", line 63, in <module>
    class report_xls(report_sxw):
  File "/opt/odoo/available/OCA/reporting-engine/report_xls/report_xls.py", line 230, in report_xls
    row_style=default_style, set_column_size=False):
NameError: name 'default_style' is not defined

@Tecnativa

Otherwise you can get errors like:

```
    from . import reporting_xls
  File "/opt/odoo/available/OCA/l10n-spain/account_balance_reporting_xls/report/reporting_xls.py", line#
Please enter the commit message for your changes. Lines starting
 31, in <module># with '#' will be ignored, and an empty message aborts the commit.
    from openerp.addons.report_xls.report_xls import report_xls# On branch 8.0-report_xls-protected_import
  File "/opt/odoo/available/OCA/OCB/openerp/modules/module.py", line 80, in load_module# Changes to be
committed:
    mod = imp.load_module('openerp.addons.' + module_part, f, path, descr)# modified: report_xls.py
  File "/opt/odoo/available/OCA/reporting-engine/report_xls/__init__.py", line 24, in <module>#
    from . import report_xls
  File "/opt/odoo/available/OCA/reporting-engine/report_xls/report_xls.py", line 63, in <module>
    class report_xls(report_sxw):
  File "/opt/odoo/available/OCA/reporting-engine/report_xls/report_xls.py", line 230, in report_xls
    row_style=default_style, set_column_size=False):
NameError: name 'default_style' is not defined
```
@pedrobaeza
Copy link
Member

👍

1 similar comment
@lasley
Copy link

lasley commented Aug 17, 2016

👍

@pedrobaeza
Copy link
Member

Fast-tracking...

@pedrobaeza pedrobaeza merged commit 21d65b4 into OCA:8.0 Aug 17, 2016
@pedrobaeza pedrobaeza deleted the 8.0-report_xls-protected_import branch August 17, 2016 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants