[FIX] runbot_travis2docker: Fix server options

[lasley]

• Fix interpolation on server options due to multi line

This should fix log issue reported in #105. Multiline string & .format weren't playing nicely, resulting in the following in SERVER_OPTIONS:

"--log-db=postgres://{cfg[db_user]}:{cfg[db_password]}@localhost/runbot"

[moylop260]

Sorry, I don't understand what is wrong with the original runbot-formating

Could you help to understand?

[lasley]

@moylop260 We added #94 to allow for log-db to work using Travis2Docker. In #94, I used basically the same code you linked from Odoo.

The difference between our's and their's is PEP8. The string is multiline, but the format is only on the last. This PR makes the string itself single line in order for the interpolation to affect all of it instead of just the second part.

[lasley]

Contrived example:

>>> '{a[test]}'+ \
... '{a[test]}'.format(a={'test':'test val'})
'{a[test]}test val'

[moylop260]

I got it
Thanks for clarify

[moylop260]

What about use:

('postgres://{cfg[db_user]}:{cfg[db_password]}@'
 '{cfg[db_host]}/{db}').format(cfg=config, db=cr.dbname)

?

[lasley]

IMO the string not spanning multiple lines looks better, but I have no explicit preference. I was also adhering to the OCA convention to use % over .format

[moylop260]

You are right!

[moylop260]

Thanks!