Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.0][FIX] runbot_travis2docker: Support ssh URIs #118

Merged
merged 1 commit into from
Feb 3, 2017
Merged

[9.0][FIX] runbot_travis2docker: Support ssh URIs #118

merged 1 commit into from
Feb 3, 2017

Conversation

lasley
Copy link
Contributor

@lasley lasley commented Feb 3, 2017

  • Support URIs prefixed with ssh:// to allow for git over SSH on non-default ports

@lasley
[FIX] runbot_travis2docker: Support ssh URIs
30ed00f 
* Support URIs prefixed with ssh:// to allow for git over SSH on non-default ports
@lasley lasley changed the title [FIX] runbot_travis2docker: Support ssh URIs [9.0][FIX] runbot_travis2docker: Support ssh URIs Feb 3, 2017
@moylop260 moylop260 merged commit 8e206fd into OCA:9.0 Feb 3, 2017
@lasley lasley deleted the hotfix/t2d-handle-ssh-uri branch February 3, 2017 17:37
@lasley
Copy link
Contributor Author

lasley commented Feb 3, 2017 •
edited

Woot thanks for the quick-merge - this was breaking my prod CI. I don't want to admit how long it took me to find this 😖

@moylop260
Copy link
Contributor

Maybe we should looking for a alternative fix related with fix repo names and protocol handling with https urls

@gurneyalex What do you think?

@lasley
Copy link
Contributor Author

lasley commented Feb 4, 2017

Probably a good idea - the fix here still doesn't support http:// or user prefixes other than git@, both of which could still happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moylop260 moylop260 moylop260 approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lasley @moylop260 @pedrobaeza