[ADD] runbot_buildout #154

hbrunn · 2018-04-26T15:13:41Z

No description provided.

moylop260 · 2018-04-26T15:36:01Z

runbot_buildout/models/runbot_build.py

+            if os.path.exists(self._path(odoo_part, 'odoo')):
+                return self._path(odoo_part, 'odoo', *l, **kw)
+            return self._path(odoo_part, 'openerp', *l, **kw)
+        else:


else-return is not needed if you if section uses a return
You can use just return ... without else

What about use return early?

if not self.repo_id.uses_buildout: return ... # My code for uses_buildout without nested `if` and without `else` reduce cyclomatic complex

moylop260 · 2018-04-26T15:39:33Z

runbot_buildout/models/runbot_build.py

+                lock_path, log_path,
+            )
+        else:
+            return super(RunbotBuild, self)._job_00_init(


if I have build.repo_id.uses_buildout=True but don't have build.branch_id.buildout_version should continue the normal runbot process?

moylop260 · 2018-04-26T15:41:44Z

runbot_buildout/models/runbot_build.py

+    @api.multi
+    def _spawn_buildout(self, cmd, lock_path, log_path):
+        self.ensure_one()
+        out = open(log_path, "w")


When is this file closed?

by now a few lines below, thanks for this one

Ok, What about use with open(log_path, "w") in order to ensure that this file is closed if there is an error in the middle.

moylop260 · 2018-04-26T15:43:36Z

runbot_buildout/models/runbot_build.py

+            })
+            self._github_status()
+            return False
+        buildout_file = tempfile.NamedTemporaryFile(


What about use with?

with tempfile... as buildout_file: buildout_file.write(adapted_buildout)

moylop260 · 2018-04-26T15:44:12Z

runbot_buildout/tests/test_runbot_buildout.py

+            'branch_id': branch.id,
+            'name': '42',
+        })
+        self.assertIn('parts/', build._server())


Is possible add a real tests running all jobs using a repo of example real?

moylop260 · 2018-04-26T15:45:27Z

Oh sorry I didn't the WIP label

hbrunn · 2018-04-26T18:13:21Z

thanks for your input anyways, some of your points I didn't think about

hbrunn · 2018-05-31T17:26:08Z

@moylop260 this is reviewable by now. Seems like there was an incompatible change in runbot: https://travis-ci.org/OCA/runbot-addons/jobs/386271662#L2709

moylop260 · 2018-06-04T17:24:09Z

@hbrunn
FYI I have fixed from
#160

thomaspaulb · 2018-06-05T19:32:20Z

runbot_buildout/models/runbot_build.py

+        ) as buildout_file:
+            buildout_file.write(bytes(
+                '[buildout]\n'
+                'extensions = buildout.wheel\n'


Probably we then also have to change this?

yes, and I'm going to ruhtlessly steal your snippet to use newer setuptools

runbot_buildout/static/src/js/runbot_buildout.js

moylop260 · 2018-06-29T17:48:31Z

.travis.yml

@@ -1,7 +1,7 @@
 language: python

 python:
-  - "3.5"
+  - "3.6"


Why python 3.6?
I mean, odoo uses by default 3.5

i have no idea. Must have been a leftover from me working frantically to get the tests running, there were very weird errors

moylop260 · 2018-06-29T17:49:22Z

.travis.yml

+  # only install extra dependencies when we're not linting
+  - pip install zc.recipe.egg --no-cache-dir
+  # the latest package on pip doesn't speak python3
+  - pip install https://github.com/anybox/anybox.recipe.odoo/tarball/master/anybox.recipe.odoo-1.9.3.dev0.tar.gz


Is not good use requirements.txt for this case, right?

I tried to pin this to a git+https url, but that didn't work the first couple of tries and then I figured I'll just wait it out until this version is released

moylop260 · 2018-06-29T17:52:17Z

runbot_buildout/models/runbot_build.py

+    @api.multi
+    def _spawn_buildout(self, cmd, lock_path, log_path):
+        self.ensure_one()
+        out = open(log_path, "w")


Ok, What about use with open(log_path, "w") in order to ensure that this file is closed if there is an error in the middle.

moylop260

👍

moylop260 · 2018-07-04T21:29:53Z

Do you have planned squash the commits or you prefer that I use merge&squash github button?

hbrunn · 2018-07-05T05:27:48Z

I squashed them, thanks!

runbot_buildout/models/runbot_build.py

runbot_buildout/tests/test_runbot_buildout.py

hbrunn · 2018-09-18T08:30:45Z

@daramousk @thomaspaulb done

moylop260 · 2018-09-18T12:07:15Z

.travis.yml


 before_install:
  # Fix https://github.com/travis-ci/travis-ci/issues/8982#issuecomment-354357640
  - python3.5 -c "import fcntl; fcntl.fcntl(1, fcntl.F_SETFL, 0)"

 install:
+  - pip install zc.recipe.egg --no-cache-dir


Did you try using requirements.txt file?

i'll try now

gitlab uses json but runbot uses http since that github supports both (json and http)

hbrunn added the work in progress label Apr 26, 2018

hbrunn added this to the 11.0 milestone Apr 26, 2018

moylop260 reviewed Apr 26, 2018

View reviewed changes

hbrunn mentioned this pull request May 3, 2018

8.0 runbot buildout #130

Closed

hbrunn force-pushed the 11.0-runbot_buildout branch 3 times, most recently from ac4c3c7 to 4e71038 Compare May 31, 2018 16:56

hbrunn added needs review and removed work in progress labels May 31, 2018

hbrunn force-pushed the 11.0-runbot_buildout branch 3 times, most recently from cbeb45c to 2ad3b1f Compare June 5, 2018 16:57

thomaspaulb reviewed Jun 5, 2018

View reviewed changes

daramousk reviewed Jun 5, 2018

View reviewed changes

runbot_buildout/static/src/js/runbot_buildout.js Outdated Show resolved Hide resolved

hbrunn force-pushed the 11.0-runbot_buildout branch 4 times, most recently from 80019a9 to 2782c1d Compare June 7, 2018 14:11

hbrunn force-pushed the 11.0-runbot_buildout branch from 170d414 to d4a67e1 Compare June 18, 2018 08:24

emagdalenaC2i mentioned this pull request Jun 21, 2018

Migration to version 11.0 #143

Open

6 tasks

hbrunn force-pushed the 11.0-runbot_buildout branch 3 times, most recently from 1f1abe1 to b54447b Compare June 28, 2018 06:22

moylop260 reviewed Jun 29, 2018

View reviewed changes

moylop260 approved these changes Jul 4, 2018

View reviewed changes

hbrunn force-pushed the 11.0-runbot_buildout branch from 2b27fa9 to 90be709 Compare July 5, 2018 05:27

daramousk reviewed Jul 18, 2018

View reviewed changes

runbot_buildout/models/runbot_build.py Outdated Show resolved Hide resolved

runbot_buildout/tests/test_runbot_buildout.py Outdated Show resolved Hide resolved

runbot_buildout/tests/test_runbot_buildout.py Outdated Show resolved Hide resolved

hbrunn force-pushed the 11.0-runbot_buildout branch 3 times, most recently from 0570e17 to 1982c66 Compare September 18, 2018 07:43

hbrunn added 2 commits September 18, 2018 10:01

[ADD] runbot_buildout

6f77ffc

[ADD] paralellize tests for modules that won't ever run together anyways

e66bab6

hbrunn force-pushed the 11.0-runbot_buildout branch from 1be96be to e66bab6 Compare September 18, 2018 08:01

daramousk approved these changes Sep 18, 2018

View reviewed changes

moylop260 reviewed Sep 18, 2018

View reviewed changes

fixup! [ADD] runbot_buildout

0cffa61

moylop260 merged commit f88bc3e into OCA:11.0 Sep 18, 2018

NL66278 pushed a commit to NL66278/runbot-addons that referenced this pull request Jan 23, 2019

[FIX] runbot_gitlab_minimal: hook - Use json hook because (OCA#154)

ca05fa4

gitlab uses json but runbot uses http since that github supports both (json and http)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD] runbot_buildout #154

[ADD] runbot_buildout #154

hbrunn commented Apr 26, 2018

moylop260 Apr 26, 2018

moylop260 Apr 26, 2018

moylop260 Apr 26, 2018

moylop260 Apr 26, 2018

hbrunn May 3, 2018

moylop260 Jun 29, 2018

moylop260 Apr 26, 2018

moylop260 Apr 26, 2018

moylop260 commented Apr 26, 2018

hbrunn commented Apr 26, 2018

hbrunn commented May 31, 2018

moylop260 commented Jun 4, 2018

thomaspaulb Jun 5, 2018

hbrunn Jun 6, 2018

moylop260 Jun 29, 2018

hbrunn Jul 2, 2018

moylop260 Jun 29, 2018

hbrunn Jul 2, 2018

moylop260 Jun 29, 2018

moylop260 left a comment

moylop260 commented Jul 4, 2018

hbrunn commented Jul 5, 2018

hbrunn commented Sep 18, 2018

moylop260 Sep 18, 2018

hbrunn Sep 18, 2018

[ADD] runbot_buildout #154

[ADD] runbot_buildout #154

Conversation

hbrunn commented Apr 26, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moylop260 commented Apr 26, 2018

hbrunn commented Apr 26, 2018

hbrunn commented May 31, 2018

moylop260 commented Jun 4, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moylop260 left a comment

Choose a reason for hiding this comment

moylop260 commented Jul 4, 2018

hbrunn commented Jul 5, 2018

hbrunn commented Sep 18, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment