[FIX] runbot_travis2docker: Remove db parameter in URLs when t2d is used #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed (Vauxoo#168) When builds are generated using travis2docker, the database name will always be set to `openerp_test`. Therefore, the db name given by default by Runbot should not be used in the build' sign in URL. This change ensures URLs include the db name parameter only when the build was not generated using travis2docker. In addition, this hides the "Connect base" button when the build was not generated using travis2docker, because the database *-base is not created in such cases.
|
CC @moylop260 |
moylop260
approved these changes
May 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When builds are generated using travis2docker, the database name will
always be set to
openerp_test. Therefore, the db name given by defaultby Runbot should not be used in the build' sign in URL.
This change ensures URLs include the db name parameter only when the
build was not generated using travis2docker.
In addition, this hides the "Connect base" button when the build was not
generated using travis2docker, because the database *-base is not
created in such cases.