Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0] [ADD] Account Fiscal Position Allowed Journal Sale #24

Open
wants to merge 2 commits into
base: 13.0
Choose a base branch
from
Open

[13.0] [ADD] Account Fiscal Position Allowed Journal Sale #24

wants to merge 2 commits into from

Conversation

ThomasBinsfeld
Copy link

acsonefho
acsonefho approved these changes Mar 20, 2020
View reviewed changes
Copy link

@acsonefho acsonefho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ThomasBinsfeld ThomasBinsfeld force-pushed the 13.0-add_account_fiscal_position_allowed_journal_sale_tbi branch from 90058d0 to cdff6ea Compare March 30, 2020 07:29
chrisdec
chrisdec approved these changes Oct 7, 2020
View reviewed changes
Copy link

@chrisdec chrisdec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

gurneyalex
gurneyalex reviewed Dec 8, 2020
View reviewed changes
.travis.yml
- git clone --branch 13.0-add_account_fiscal_position_allowed_journal_tbi
https://github.com/acsone/account-financial-tools.git PR937
- rm -rf account_fiscal_position_allowed_journal && cp -ar
PR937/account_fiscal_position_allowed_journal .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OCA/account-financial-tools#937 is merged, can you remove this?

@dreispt
Copy link
Sponsor Member

dreispt commented Nov 27, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-24-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 27, 2021
@OCA-git-bot
Merge PR #24 into 13.0
060699f 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-24-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

etobella
etobella reviewed Oct 16, 2022
View reviewed changes
.travis.yml
@@ -37,6 +37,11 @@ env:
- VERSION="13.0" TESTS="0" LINT_CHECK="0" MAKEPOT="0"

install:
# FIXME:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThomasBinsfeld Can you remove this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurneyalex gurneyalex gurneyalex left review comments

@etobella etobella etobella left review comments

@chrisdec chrisdec chrisdec approved these changes

@acsonefho acsonefho acsonefho approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ThomasBinsfeld @OCA-git-bot @dreispt @gurneyalex @chrisdec @etobella @acsonefho