Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] sale_coupon_incompatibility: Migration to version 15.0 #100

Merged
merged 6 commits into from
Mar 1, 2023
Merged

[15.0][MIG] sale_coupon_incompatibility: Migration to version 15.0 #100

merged 6 commits into from
Mar 1, 2023

Conversation

stefan-tecnativa
Copy link
Contributor

cc @Tecnativa TT38309

@chienandalu @pedrobaeza please review!

@pedrobaeza
Copy link
Member

/ocabot migration sale_coupon_incompatibility

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Jan 30, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 30, 2023
Open
21 tasks
pedrobaeza
pedrobaeza reviewed Jan 30, 2023
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this module be just coupon_incompatibility and apply in a generic way?

@stefan-tecnativa
Copy link
Contributor Author

Can this module be just coupon_incompatibility and apply in a generic way?

This name alone could be confusing, but in the context of sale-promotion I think you can understand its purpose. What do you think @chienandalu ?

chienandalu
chienandalu reviewed Jan 31, 2023
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow the same pattern as in da66de1

@stefan-tecnativa
Copy link
Contributor Author

Follow the same pattern as in da66de1

@chienandalu @pedrobaeza is this the correct way?

chienandalu
chienandalu suggested changes Feb 2, 2023
View reviewed changes
coupon_incompatibility/models/coupon_program.py Outdated Show resolved Hide resolved
coupon_incompatibility/models/coupon_program.py Outdated Show resolved Hide resolved
sale_coupon_incompatibility/models/sale_coupon_program.py Outdated Show resolved Hide resolved
sale_coupon_incompatibility/models/sale_coupon_program.py Outdated Show resolved Hide resolved
@stefan-tecnativa stefan-tecnativa force-pushed the 15.0-mig-sale_coupon_incompatibility branch from d82d174 to d6daa2e Compare February 3, 2023 08:01
chienandalu
chienandalu suggested changes Feb 7, 2023
View reviewed changes
coupon_incompatibility/readme/USAGE.rst Outdated
@@ -0,0 +1,5 @@
Once you've configured your incompatibilities, go to a quotations that fulfills your
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should split the readme to fit each part purpose

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had already made the split, but I forgot to remove this part.

@stefan-tecnativa stefan-tecnativa force-pushed the 15.0-mig-sale_coupon_incompatibility branch from d6daa2e to 4af3181 Compare February 7, 2023 11:14
chienandalu
chienandalu suggested changes Feb 7, 2023
View reviewed changes
coupon_incompatibility/readme/CONFIGURE.rst Outdated
Comment on lines 6 to 7
#. Once set, the those promotions will have your configured promotion as incompatible
as well, so they can't be used altogether in the same sale order.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#. Once set, the those promotions will have your configured promotion as incompatible
as well, so they can't be used altogether in the same sale order.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@chienandalu
Copy link
Member

Also regenerate both readmes

@stefan-tecnativa stefan-tecnativa force-pushed the 15.0-mig-sale_coupon_incompatibility branch from 4af3181 to 5e31b10 Compare February 8, 2023 07:24
chienandalu
chienandalu approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor last comment. Otherwise 👍

sale_coupon_incompatibility/models/sale_coupon.py Outdated Show resolved Hide resolved
@stefan-tecnativa stefan-tecnativa force-pushed the 15.0-mig-sale_coupon_incompatibility branch from 5e31b10 to 0ba4620 Compare February 28, 2023 07:46
@stefan-tecnativa
[IMP] coupon_incompatibility, sale_coupon_incompatibility
37179a8 
Allow coupon_incompatibility settings to be used by other modules.
@stefan-tecnativa stefan-tecnativa force-pushed the 15.0-mig-sale_coupon_incompatibility branch from 0ba4620 to 37179a8 Compare March 1, 2023 07:00
chienandalu
chienandalu approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

pedrobaeza
pedrobaeza approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-100-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d41fd50 into OCA:15.0 Mar 1, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4135f2b. Thanks a lot for contributing to OCA. ❤️

pilarvargas-tecnativa pushed a commit to Tecnativa/sale-promotion that referenced this pull request May 30, 2023
@OCA-git-bot
Merge PR OCA#100 into 15.0
94ca1cc 
Signed-off-by pedrobaeza
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chienandalu chienandalu chienandalu approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stefan-tecnativa @pedrobaeza @chienandalu @OCA-git-bot