[15.0][MIG] sale_coupon_auto_refresh: Migration to version 15.0 #102
Conversation
…r refactoring for better inheritability
When applying a promo code via wizard, Odoo creates a sale.order.line *before* filling the sale.order 'code_promo_program_id' field. After the creation, though, the auto refresh override kicks in, calling the 'recompute_coupon_lines' method. That method finds a sale.order.line that was created from a promo program, but such program is not linked to the sale.order, and so the line gets deleted. However, since the line has just been created, Odoo will try to run the '_check_company' method on it, which will try to read the field 'company_id' of the deleted line. This operation will result in a MissingError, raised by the '__get__' method of Field class. This error is fixed by adding the 'skip_auto_refresh_coupons' flag to the wizard context when executing the 'process_coupon' method.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-promotion-14.0/sale-promotion-14.0-sale_coupon_auto_refresh Translate-URL: https://translation.odoo-community.org/projects/sale-promotion-14-0/sale-promotion-14-0-sale_coupon_auto_refresh/
Currently translated at 100.0% (14 of 14 strings) Translation: sale-promotion-14.0/sale-promotion-14.0-sale_coupon_auto_refresh Translate-URL: https://translation.odoo-community.org/projects/sale-promotion-14-0/sale-promotion-14-0-sale_coupon_auto_refresh/zh_CN/
Currently translated at 100.0% (14 of 14 strings) Translation: sale-promotion-14.0/sale-promotion-14.0-sale_coupon_auto_refresh Translate-URL: https://translation.odoo-community.org/projects/sale-promotion-14-0/sale-promotion-14-0-sale_coupon_auto_refresh/fr/
we need to pass skip_auto_refresh_coupons=True in the context when adding / editing / removing lines otherwise we can end up with the promotion line being added twice or removed twice (the latter causing a crash)
This commit, alongside with odoo/odoo#77989, fixes MissingError being raised when: - the line(s) that allow coupons to be applied are deleted - the line(s) that allow coupons to be applied are updated making coupons applicable no more Moreover: - a check on which fields are updated is introduced in order to boost performances - the module has been slightly refactored for better readability Closes OCA#20
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-promotion-14.0/sale-promotion-14.0-sale_coupon_auto_refresh Translate-URL: https://translation.odoo-community.org/projects/sale-promotion-14-0/sale-promotion-14-0-sale_coupon_auto_refresh/
Currently translated at 6.2% (1 of 16 strings) Translation: sale-promotion-14.0/sale-promotion-14.0-sale_coupon_auto_refresh Translate-URL: https://translation.odoo-community.org/projects/sale-promotion-14-0/sale-promotion-14-0-sale_coupon_auto_refresh/it/
Currently translated at 100.0% (16 of 16 strings) Translation: sale-promotion-14.0/sale-promotion-14.0-sale_coupon_auto_refresh Translate-URL: https://translation.odoo-community.org/projects/sale-promotion-14-0/sale-promotion-14-0-sale_coupon_auto_refresh/it/
This can allow us to work altogether with flexible triggers like the ones we could need with sale_coupon_criteria_order_based TT37479
We should not refresh the lines before the proccess of applying the coupon is finished. TT38806
pilarvargas-tecnativa
force-pushed
the
15.0-mig-sale_coupon_auto_refresh
branch
from
c5ca9b7
to
767e4b4
Compare
pilarvargas-tecnativa
changed the title
|
Please rename the migration commit from |
Use the new `get_depends()` method as the former `depends` attribute (now in `_depends`) is no longer reliable.
pilarvargas-tecnativa
force-pushed
the
15.0-mig-sale_coupon_auto_refresh
branch
from
26767c5
to
356af8f
Compare
Sorry I didn't realise, it's changed, thanks! |
|
On my way to merge this fine PR! |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-102-by-pedrobaeza-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-102-by-pedrobaeza-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at e767b9e. Thanks a lot for contributing to OCA. ❤️ |
cc @Tecnativa TT37307
@chienandalu @victoralmau please review