[15.0][MIG] website_sale_coupon_restrict: Migration to version 15.0 #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chienandalu
suggested changes
Feb 15, 2023
|
|
||
| def _check_coupon_code(self, order): | ||
| def _check_coupon_code(self, order_date, partner_id, **kwargs): | ||
| order = kwargs.get("order", False) | ||
| if self.program_id.website_only and not order.website_id: |
There was a problem hiding this comment.
You should check if order exists as well
There was a problem hiding this comment.
Done, thanks for the suggest
|
Not sure if in this case it's worth the split, being this totally oriented to e-commerce |
Yes, that's right, we're depending on website_sale_coupon, so the comment isn't relevant. |
stefan-tecnativa
force-pushed
the
15.0-mig-website_sale_coupon_restrict
branch
from
256ed45
to
797a464
Compare
chienandalu
suggested changes
Feb 17, 2023
website_sale_coupon_restrict/views/sale_coupon_program_views.xml
Outdated
Show resolved
Hide resolved
stefan-tecnativa
force-pushed
the
15.0-mig-website_sale_coupon_restrict
branch
from
797a464
to
7d7f1c8
Compare
chienandalu
approved these changes
Feb 17, 2023
|
Ready to merge @pedrobaeza |
|
/ocabot migration website_sale_coupon_restrict |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 8cf5601. Thanks a lot for contributing to OCA. ❤️ |
pilarvargas-tecnativa
pushed a commit
to Tecnativa/sale-promotion
that referenced
this pull request
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc@Tecnativa TT37333
@chienandalu @CarlosRoca13 please review!