Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] sale_coupon_domain_product_discount: Migration to version 15.0 #112

Merged

Conversation

stefan-tecnativa
Copy link
Contributor

cc@Tecnativa TT38308

@chienandalu @pedrobaeza please review!

@stefan-tecnativa
Copy link
Contributor Author

This module can be splitted, i will commit it when it's done

@stefan-tecnativa stefan-tecnativa force-pushed the 15.0-mig-sale_coupon_domain_product_discount branch from 53e115a to 4b11d7a Compare February 22, 2023 08:33
@chienandalu
Copy link
Member

You can split it now

@stefan-tecnativa stefan-tecnativa force-pushed the 15.0-mig-sale_coupon_domain_product_discount branch 2 times, most recently from 7a86ef6 to a7e0c32 Compare February 23, 2023 07:48
}
)
# Let's prepare a sale order to play with
sale_form = Form(cls.env["sale.order"])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This declaration should go in the sales module

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@stefan-tecnativa stefan-tecnativa force-pushed the 15.0-mig-sale_coupon_domain_product_discount branch from a7e0c32 to adb2f6a Compare February 27, 2023 10:42
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@pedrobaeza
Copy link
Member

/ocabot migration sale_coupon_domain_product_discount

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Feb 27, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 27, 2023
21 tasks
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon.png file is incorrect.

…ount

Allow sale_coupon_domain_product_discount setting to be used by other modules
@stefan-tecnativa stefan-tecnativa force-pushed the 15.0-mig-sale_coupon_domain_product_discount branch from adb2f6a to 2077b15 Compare February 28, 2023 07:43
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-112-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 5a999c1 into OCA:15.0 Mar 1, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3c6e328. Thanks a lot for contributing to OCA. ❤️

pilarvargas-tecnativa pushed a commit to Tecnativa/sale-promotion that referenced this pull request May 30, 2023
Signed-off-by pedrobaeza
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants