Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] sale_coupon_multiple_code_program: Migration to version 15.0 #118

Merged

Conversation

stefan-tecnativa
Copy link
Contributor

cc@Tecnativa TT39650

@chienandalu @CarlosRoca13 please review!

Copy link
Contributor

@CarlosRoca13 CarlosRoca13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pedrobaeza
Copy link
Member

/ocabot migration sale_coupon_multiple_code_program

Shouldn't this be split into 2 modules?

@chienandalu
Copy link
Member

No, it's exclusive to sales as it does the hack over a sale.order field

@pedrobaeza
Copy link
Member

The context stuff on search of the coupon.program may be generic, but OK to not split for theoretical cases. When we need it on PoS, we'll split.

/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Feb 24, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 24, 2023
21 tasks
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-118-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7a63493 into OCA:15.0 Feb 24, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f523dcb. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-mig-sale_coupon_multiple_code_program branch February 24, 2023 10:01
pilarvargas-tecnativa pushed a commit to Tecnativa/sale-promotion that referenced this pull request May 30, 2023
Signed-off-by pedrobaeza
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants