Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] sale_coupon_partner #125

Merged
merged 3 commits into from
Apr 18, 2023
Merged

[14.0][MIG] sale_coupon_partner #125

merged 3 commits into from
Apr 18, 2023

Conversation

dessanhemrayev
Copy link

Migration to 14.0

CarlosRoca13 and others added 2 commits April 13, 2023 12:45
@CarlosRoca13 @dessanhemrayev
[ADD] sale_coupon_program: New module that links a sale_coupon_progra…
c528b08 
…m with a partner.

This module adds the possibility of link a sale.coupon.program with a res.partner and allow to filter it on Sale Analysis.
@dessanhemrayev
[IMP] : black, isort, prettier
6ac2d99
@dessanhemrayev dessanhemrayev force-pushed the 14.0-t2467-sale_coupon_partner-mig branch from b5ee7ac to 4538284 Compare April 13, 2023 10:04
@dessanhemrayev dessanhemrayev marked this pull request as draft April 13, 2023 10:08
@dessanhemrayev dessanhemrayev force-pushed the 14.0-t2467-sale_coupon_partner-mig branch 2 times, most recently from d38e3b7 to 6f1873d Compare April 13, 2023 10:17
@dessanhemrayev dessanhemrayev marked this pull request as ready for review April 13, 2023 10:20
@dessanhemrayev dessanhemrayev force-pushed the 14.0-t2467-sale_coupon_partner-mig branch from 6f1873d to aedbbae Compare April 13, 2023 11:32
francesco-ooops
francesco-ooops approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

geomer198
geomer198 approved these changes Apr 14, 2023
View reviewed changes
Copy link

@geomer198 geomer198 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@francesco-ooops
Copy link
Contributor

@pedrobaeza go? :)

@pedrobaeza
Copy link
Member

/ocabot migration sale_coupon_partner
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 14.0 milestone Apr 18, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 18, 2023
Open
5 tasks
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-125-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6b9d7df into OCA:14.0 Apr 18, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1f0d63c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francesco-ooops francesco-ooops francesco-ooops approved these changes

@geomer198 geomer198 geomer198 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dessanhemrayev @OCA-git-bot @francesco-ooops @pedrobaeza @geomer198 @CarlosRoca13