[16.0][MIG] sale_coupon_order_line_link > sale_loyalty_order_line_link: Migration to version 16.0 #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technical module linking order lines with programs TT30850
Filter lines that are related to a reward: either they genereted it or
the reward is applied to them. For example:
- A promotion product domain could be: ("id", "=" product_a.id)
- The same promotion has a reward product B
- On a sale order with products A, B and C:
- A reward line will be generated to discount B's amount and will be
linked to the promotion.
- Line A will have a link to the reward line as it was the condition
for the promotion.
- Line B will also have a link to the reward line as it's the line
over which the discount is made.
TT31755
On the reward lines we can just invert the relation comlumns to have the lines that generated them. TT31755
We can now view which promotions are applied visually. TT35401
If a third module adds an extra discount scope, we should: - Allow integration returning always at least an empty object - Allow compatibility by inheritance hooking into the method that defines the scoped lines. TT36131
In some cases the `recompute_coupon_lines` method could lead to miss the previously created links. We want to ensure those links at the end of such method. TT40205
Currently translated at 100.0% (15 of 15 strings) Translation: sale-promotion-15.0/sale-promotion-15.0-sale_coupon_order_line_link Translate-URL: https://translation.odoo-community.org/projects/sale-promotion-15-0/sale-promotion-15-0-sale_coupon_order_line_link/it/
sale_loyalty_order_line_link/migrations/16.0.1.0.0/post-migration.py
Outdated
Show resolved
Hide resolved
stefan-tecnativa
approved these changes
Sep 21, 2023
pilarvargas-tecnativa
force-pushed
the
16.0-mig-sale_coupon_order_line_link
branch
from
dd7dfc1
to
078406b
Compare
chienandalu
suggested changes
Sep 22, 2023
pilarvargas-tecnativa
force-pushed
the
16.0-mig-sale_coupon_order_line_link
branch
from
078406b
to
c3ee804
Compare
chienandalu
suggested changes
Sep 22, 2023
sale_loyalty_order_line_link/migrations/16.0.1.0.0/pre-migration.py
Outdated
Show resolved
Hide resolved
sale_loyalty_order_line_link/migrations/16.0.1.0.0/pre-migration.py
Outdated
Show resolved
Hide resolved
pilarvargas-tecnativa
force-pushed
the
16.0-mig-sale_coupon_order_line_link
branch
2 times, most recently
from
824bd8e
to
d6a48ec
Compare
This was referenced Sep 27, 2023
|
/ocabot migration sale_coupon_order_line_link |
pedrobaeza
reviewed
Sep 28, 2023
sale_loyalty_order_line_link/migrations/16.0.1.0.0/pre-migration.py
Outdated
Show resolved
Hide resolved
…_link + Migration to version 16.0 TT44349
pilarvargas-tecnativa
force-pushed
the
16.0-mig-sale_coupon_order_line_link
branch
from
d6a48ec
to
8fa629f
Compare
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 202a28f. Thanks a lot for contributing to OCA. ❤️ |
ernesto-garcia-tecnativa
pushed a commit
to Tecnativa/sale-promotion
that referenced
this pull request
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed to sale_loyalty_order_line_link + Migration to 16.0
cc @Tecnativa TT44349
ping @chienandalu @stefan-tecnativa