Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] coupon_limit > loyalty_limit: Migration to version 16.0 #155

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

pilarvargas-tecnativa
Copy link
Contributor

@pilarvargas-tecnativa pilarvargas-tecnativa commented Sep 27, 2023

Renamed to loyalty_limit

cc @Tecnativa TT44319

@chienandalu @ernesto-garcia-tecnativa please review

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a temporal reference to your dependency so we can se the whole picture: https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference(s)-to-another-pull-request(s)

@pilarvargas-tecnativa
Copy link
Contributor Author

Please add a temporal reference to your dependency so we can se the whole picture: https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference(s)-to-another-pull-request(s)

thanks :)

Allow coupon_limit settings to be used by other loyalty modules
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Some doubts though:

loyalty_limit/migrations/16.0.1.0.0/pre-migration.py Outdated Show resolved Hide resolved
@pilarvargas-tecnativa
Copy link
Contributor Author

@CarlosRoca13 take a look please

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go :)

@pilarvargas-tecnativa
Copy link
Contributor Author

ping @pedrobaeza :D

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-155-by-pedrobaeza-bump-nobump, awaiting test results.

@pedrobaeza
Copy link
Member

/ocabot migration coupon_limit

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Nov 16, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 16, 2023
14 tasks
@OCA-git-bot OCA-git-bot merged commit c2068bf into OCA:16.0 Nov 16, 2023
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e026465. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-mig-coupon_limit branch November 16, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants