Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] coupon_incompatibility: Migration to version 16.0 #157

Closed
wants to merge 4 commits into from
Closed

[16.0][MIG] coupon_incompatibility: Migration to version 16.0 #157

wants to merge 4 commits into from

Conversation

ernesto-garcia-tecnativa
Copy link

@Tecnativa TT44318

@ernesto-garcia-tecnativa
Copy link
Author

@pedrobaeza @chienandalu please review

@pedrobaeza
Copy link
Member

It should be renamed (with all the history) to loyalty_incompatibility.

stefan-tecnativa and others added 3 commits October 5, 2023 11:05
@stefan-tecnativa @ernesto-garcia-tecnativa
[IMP] coupon_incompatibility, sale_coupon_incompatibility
4354bab 
Allow coupon_incompatibility settings to be used by other modules.
@weblate @ernesto-garcia-tecnativa
Update translation files
e429f90 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-promotion-15.0/sale-promotion-15.0-coupon_incompatibility
Translate-URL: https://translation.odoo-community.org/projects/sale-promotion-15-0/sale-promotion-15-0-coupon_incompatibility/
@ernesto-garcia-tecnativa
[IMP] coupon_incompatibility: pre-commit stuff
c3740b8
@ernesto-garcia-tecnativa ernesto-garcia-tecnativa force-pushed the 16.0-mig-coupon_incompatibility branch 3 times, most recently from 5dd36d6 to 7f06d73 Compare October 5, 2023 17:13
@ernesto-garcia-tecnativa
Copy link
Author

It should be renamed (with all the history) to loyalty_incompatibility.

Done and pushed @pedrobaeza

@pedrobaeza
Copy link
Member

/ocabot migration coupon_incompatibility

Change the message of the last commit to [MIG] coupon_incompatibility: Migration to 16.0 and renamed to loyal_incompatibility.

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Oct 5, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Sep 29, 2023
Open
14 tasks
@pedrobaeza
Copy link
Member

Rename also the POT and replace the PO/POT content with the proper module name.

chienandalu
chienandalu suggested changes Oct 6, 2023
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ernesto-garcia-tecnativa

  • Keep it open so we can test it in your sale_loyalty_incompatibility migration
  • Some remarks:

loyalty_incompatibility/views/sale_coupon_program_views.xml Outdated Show resolved Hide resolved
loyalty_incompatibility/views/sale_coupon_program_views.xml Outdated Show resolved Hide resolved
loyalty_incompatibility/models/coupon_program.py Outdated Show resolved Hide resolved
loyalty_incompatibility/models/__init__.py Outdated Show resolved Hide resolved
loyalty_incompatibility/tests/test_coupon_incompatibility.py Outdated Show resolved Hide resolved
loyalty_incompatibility/tests/test_coupon_incompatibility.py Outdated Show resolved Hide resolved
loyalty_incompatibility/models/coupon_program.py Outdated Show resolved Hide resolved
@ernesto-garcia-tecnativa
Copy link
Author

@chienandalu please review

@chienandalu
Copy link
Member

@chienandalu please review

Please do the sale_coupon_incompatibility migration adding this PR as a dependency. Here's the guide to do so: https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference(s)-to-another-pull-request(s)

@ernesto-garcia-tecnativa ernesto-garcia-tecnativa mentioned this pull request Oct 17, 2023
Closed
1 task
@pilarvargas-tecnativa pilarvargas-tecnativa mentioned this pull request Nov 20, 2023
Merged
@pedrobaeza pedrobaeza closed this Dec 5, 2023
@pedrobaeza pedrobaeza deleted the 16.0-mig-coupon_incompatibility branch December 5, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chienandalu chienandalu chienandalu requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ernesto-garcia-tecnativa @pedrobaeza @chienandalu @OCA-git-bot @stefan-tecnativa @weblate