Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] sale_coupon_incompatibility>sale_loyalty_incompatibility: Migration to version 16.0 #180

Merged

Conversation

pilarvargas-tecnativa
Copy link
Contributor

@pedrobaeza
Copy link
Member

/ocabot migration sale_coupon_incompatibility

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to fix the temp deps commit

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-imp-sale_loyalty_incompatibility branch 2 times, most recently from fff2f93 to be2b254 Compare January 22, 2024 10:10
@pilarvargas-tecnativa
Copy link
Contributor Author

ping @chienandalu

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 👍 Some formal comments

sale_loyalty_incompatibility/__manifest__.py Outdated Show resolved Hide resolved
sale_loyalty_incompatibility/i18n/es.po Outdated Show resolved Hide resolved
sale_loyalty_incompatibility/__manifest__.py Outdated Show resolved Hide resolved
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-imp-sale_loyalty_incompatibility branch from be2b254 to c34d4cf Compare January 22, 2024 12:06
@pilarvargas-tecnativa
Copy link
Contributor Author

@CarlosRoca13 can you review please?

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-imp-sale_loyalty_incompatibility branch from c34d4cf to 0e68f48 Compare February 2, 2024 15:57
@pilarvargas-tecnativa
Copy link
Contributor Author

ping @pedrobaeza :)

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-180-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b58f8c4 into OCA:16.0 Feb 2, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2064d5c. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-imp-sale_loyalty_incompatibility branch February 2, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants