Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] sale_coupon_criteria_multi_product > sale_loyalty_criteria_multi_product: Migration to version 16.0 #185

Open
wants to merge 7 commits into
base: 16.0
Choose a base branch
from

Conversation

pilarvargas-tecnativa
Copy link
Contributor

@pilarvargas-tecnativa pilarvargas-tecnativa commented Nov 29, 2023

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check tests

@pedrobaeza
Copy link
Member

/ocabot migration sale_coupon_criteria_multi_product

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Nov 29, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 24, 2023
14 tasks
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-imp-sale_coupon_criteria_multi_product branch from be7a29e to 9d1a281 Compare November 30, 2023 14:20
@pilarvargas-tecnativa
Copy link
Contributor Author

Check tests

solved :)

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happenend to the repeat column?

image

Also, unrelated error but please check it:

image

@pilarvargas-tecnativa
Copy link
Contributor Author

What happenend to the repeat column?

This functionality is already included in the rules of the program itself, I have indicated it in the context of the base module. I have considered duplicating that functionality.

https://github.com/OCA/sale-promotion/blob/35cbd00cc5ff21ba0a2f0b0873dfa37dc639e335/loyalty_criteria_multi_product/readme/CONTEXT.rst

Also, unrelated error but please check it:

I'm going to check it

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-imp-sale_coupon_criteria_multi_product branch from 9d1a281 to f828cce Compare January 29, 2024 16:37
@pilarvargas-tecnativa
Copy link
Contributor Author

ping @chienandalu

@pilarvargas-tecnativa pilarvargas-tecnativa changed the title [16.0][MIG] sale_coupon_criteria_multi_product: Migration to version 16.0 [16.0][MIG] sale_coupon_criteria_multi_product > sale_loyalty_criteria_multi_product: Migration to version 16.0 Jan 31, 2024
@chienandalu
Copy link
Member

Rebase and drop the deps commit

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-imp-sale_coupon_criteria_multi_product branch from f828cce to 2cb792e Compare February 28, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants