[14.0][MIG] sale_coupon_order_line_link: Migration to 14.0 #53
Conversation
Technical module linking order lines with programs TT30850
Filter lines that are related to a reward: either they genereted it or
the reward is applied to them. For example:
- A promotion product domain could be: ("id", "=" product_a.id)
- The same promotion has a reward product B
- On a sale order with products A, B and C:
- A reward line will be generated to discount B's amount and will be
linked to the promotion.
- Line A will have a link to the reward line as it was the condition
for the promotion.
- Line B will also have a link to the reward line as it's the line
over which the discount is made.
TT31755
On the reward lines we can just invert the relation comlumns to have the lines that generated them. TT31755
We can now view which promotions are applied visually. TT35401
| "development_status": "Production/Stable", | ||
| "category": "Sale", | ||
| "website": "https://github.com/OCA/sale-promotion", | ||
| "author": "Tecnativa, Odoo Community Association (OCA)", | ||
| "author": "Ilyas, Ooops404, Tecnativa, Odoo Community Association (OCA)", |
There was a problem hiding this comment.
I'm afraid a migration of this scope doesn't grant you co-authorship. You can put yourself on contributors though
As i understand it is not required here. But i'm not 100% sure. |
|
The migration script is needed if the data structure was changed in the new version. E.g. in v14 account.move field "type" was renamed into "move_type". If there are any similar cases in this module then the migration scripts are mandatory |
|
@pedrobaeza is it good now? :) |
|
@pedrobaeza any news for this ? |
|
@OCA/crm-sales-marketing-maintainers @pedrobaeza there is someone for review this PR ? |
|
/ocabot migration sale_coupon_order_line_link |
|
There's no issue in this repo with the title 'Migration to version 14.0' and the milestone 14.0, so not possible to add the comment. |
|
@ilyasProgrammer Thanks for this. Could you squash your last two commits into one ? |
ilyasProgrammer
force-pushed
the
14.0-mig-sale_coupon_order_line_link_2
branch
from
7879de5
to
9acf1a0
Compare
|
/ocabot migration sale_coupon_order_line_link |
|
@rousseldenis can we also merge please? 🥵 |
The merge is conditioned to approvals. There is still a pending change request from @pedrobaeza You should always first ping those users :
|
"Formally" I understand, but the remarks by @pedrobaeza were addressed a week ago, so that should not prevent merge imho anyway, @pedrobaeza could you update your review please? |
|
I'm all week on the Spanish Odoo days with little time to other activities. I'll review ASAP. |
thanks! |
pedrobaeza
changed the title
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 47323b3. Thanks a lot for contributing to OCA. ❤️ |
No description provided.