[MIG] sale_coupon_multi_gift: Migration to 14.0 #65
Conversation
Now we use the product field in the multi gift line as a mask for a many2many field that can be used by a third module as a way to offer optional gifts to the user. TT30850
|
/ocabot migration sale_coupon_multi_gift |
|
@chienandalu @pedrobaeza can you review this? |
There was a problem hiding this comment.
Hi, @carolina-domatix I'm wating for #42 to be merged so you can include it in your migration. It has some relevant changes
|
#42 merged. You can already include it in your migration |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
Hi, @carolina-domatix it seems you haven't cherry picked the commit from #42, not respecting attribution. Can you please do it? |
github-actions
bot
removed
the
stale
When we've got mixed optional rewards we need to tell for sure which reward line belongs a sale line to so we can apply the right product when the reward is updated. TT34266
|
Hi, @pedrobaeza sorry for the inconvenience and thank you for pointing that out. I think I've just fixed it. |
|
This PR has the |
|
/ocabot merge nobump |
|
@pedrobaeza can you try again? |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 57b0e65. Thanks a lot for contributing to OCA. ❤️ |
No description provided.