[MIG] sale_coupon_criteria_multi_product: Migration to 14.0 #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chienandalu
reviewed
Jun 16, 2022
|
|
||
| sale_coupon_criteria = fields.Selection( | ||
| coupon_criteria = fields.Selection( |
There was a problem hiding this comment.
Ok with the field renames (you can also do it with the filenames using git mv for better diff). Anyway, a migration script should be made. An example:
openupgrade.rename_fields reference: https://github.com/OCA/openupgradelib/blob/master/openupgradelib/openupgrade.py#L585-L611
|
Done! |
francesco-ooops
approved these changes
Jun 22, 2022
|
/ocabot migration sale_coupon_criteria_multi_product |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 601a174. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.