Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] sale_coupon_mass_mailing: Migration to version 15.0 #93

Merged
merged 4 commits into from
Jan 13, 2023
Merged

[15.0][MIG] sale_coupon_mass_mailing: Migration to version 15.0 #93

merged 4 commits into from
Jan 13, 2023

Conversation

pilarvargas-tecnativa
Copy link
Contributor

TT39004 @Tecnativa

@victoralmau @chienandalu please review

@pedrobaeza
Copy link
Member

When renaming, indicate in the last commit such renaming: [MIG] sale_coupon_mass_mailing > coupon_mass_mailing: Migration to 15.0

@pedrobaeza
Copy link
Member

/ocabot migration sale_coupon_mass_mailing

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Jan 11, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 11, 2023
Open
21 tasks
@pilarvargas-tecnativa
Copy link
Contributor Author

When renaming, indicate in the last commit such renaming: [MIG] sale_coupon_mass_mailing > coupon_mass_mailing: Migration to 15.0

OK, I have changed the commit message. Thank you!

victoralmau
victoralmau suggested changes Jan 11, 2023
View reviewed changes
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments.
Remember to do the PR to OpenUpgrade to rename the module

coupon_mass_mailing/models/sale_coupon_program.py Outdated Show resolved Hide resolved
coupon_mass_mailing/models/sale_coupon_program.py Outdated Show resolved Hide resolved
coupon_mass_mailing/models/sale_coupon_program.py Outdated Show resolved Hide resolved
@pilarvargas-tecnativa pilarvargas-tecnativa mentioned this pull request Jan 11, 2023
Merged
chienandalu
chienandalu approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Thanks! 👍

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-93-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 12, 2023
@OCA-git-bot
Merge PR #93 into 15.0
870c22c 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-93-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

1 similar comment
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-93-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

I have aborted the CI. You didn't rename the POT file nor updated the content of the files POT and PO.

@pilarvargas-tecnativa
Copy link
Contributor Author

I have aborted the CI. You didn't rename the POT file nor updated the content of the files POT and PO.

Already updated, thanks

@pedrobaeza
Copy link
Member

The POT file is still named sale_coupon_mass_mailing.pot instead of coupon_mass_mailing.pot

@pilarvargas-tecnativa
Copy link
Contributor Author

The POT file is still named sale_coupon_mass_mailing.pot instead of coupon_mass_mailing.pot

sorry, I've already renamed it

@pedrobaeza pedrobaeza reopened this Jan 13, 2023
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-93-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9c53f11 into OCA:15.0 Jan 13, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1bae319. Thanks a lot for contributing to OCA. ❤️

chienandalu pushed a commit to Tecnativa/sale-promotion that referenced this pull request Jan 26, 2023
@OCA-git-bot
Merge PR OCA#93 into 15.0
69405ef 
Signed-off-by pedrobaeza
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victoralmau victoralmau victoralmau approved these changes

@chienandalu chienandalu chienandalu approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pilarvargas-tecnativa @pedrobaeza @OCA-git-bot @victoralmau @chienandalu