Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint #15

Merged
merged 2 commits into from
Sep 10, 2014
Merged

lint #15

merged 2 commits into from
Sep 10, 2014

Conversation

lepistone
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 2bf4c37 on lepistone:7.0-lint into * on OCA:7.0*.

uos=uos, name=name, partner_id=partner_id, lang=lang,
update_tax=update_tax, date_order=date_order, packaging=packaging,
fiscal_position=fiscal_position, flag=flag, context=context)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well well well. I agree the old version was ugly, but the new one is worse imo.
with such long list of arguments, I feel 1 arg per line is far more readable.

@lepistone
Copy link
Member Author

@gurneyalex fixed

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 55772f7 on lepistone:7.0-lint into * on OCA:7.0*.

@pedrobaeza
Copy link
Member

👍

@yvaucher
Copy link
Member

👀 Those onchanges ...

👍

@gurneyalex
Copy link
Member

👍 @yvaucher 🙈

pedrobaeza added a commit that referenced this pull request Sep 10, 2014
@pedrobaeza pedrobaeza merged commit 5bd293f into OCA:7.0 Sep 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants