-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][MIG] sale_order_line_position #153
[15.0][MIG] sale_order_line_position #153
Conversation
This module adds an auto computed position on sale order line. This position number is added on the report. The position can be used to keep track of each line during the delivery, invoicing of the order with the customer. This is why there is related modules on `account-invoice-reporting` and `stock-logisics-reporting`. The position set on a line is not changed when the order is not in draft anymore.
The previous implementation with the onchange was broken and hardly feasible (onchange are called on each line and the sequence set on them changes on each call) and not possible to cover with unit tests (reproduce the drag and drop). The other solution could have been to replace the onchange with a recompute of the position on every `write` of a sale.order but that also leads to a complex solution. As the positions are needed to discuss with the customer, the recompute of the position on print, send and confirm is a good enough, simple solution.
Currently translated at 81.8% (9 of 11 strings) Translation: sale-reporting-14.0/sale-reporting-14.0-sale_order_line_position Translate-URL: https://translation.odoo-community.org/projects/sale-reporting-14-0/sale-reporting-14-0-sale_order_line_position/de/
/ocabot migration sale_order_line_position |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG but please rewrite your commits to include the module name
db29935
to
e532885
Compare
Sorry, just noticed the 1st commit before the mig is kind of useless by itself, it should be squashed on top of the migration one. |
e532885
to
32366a2
Compare
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at f6aa4d4. Thanks a lot for contributing to OCA. ❤️ |
No description provided.