[14.0][MIG] sale_layout_category_hide_detail: Migration to 14.0 #170

victoralmau · 2022-08-26T08:00:35Z

Superseed #128

Changes done:

Migration to 14.0
Do not allow to use the buttons depending on the status of the order or invoice ([14.0][MIG] sale_layout_category_hide_detail #128 (comment)).
Set a fixed width for the button columns.
Simplify code in functions to allow inheritability.

Please @pedrobaeza can you review it?

Hide details for sections in sales orders and invoices for reports and customer portal

Currently translated at 100.0% (7 of 7 strings) Translation: sale-reporting-11.0/sale-reporting-11.0-sale_layout_category_hide_detail Translate-URL: https://translation.odoo-community.org/projects/sale-reporting-11-0/sale-reporting-11-0-sale_layout_category_hide_detail/es/

…nvoice" Propagate values in 'Show details' and 'Show subtotal' fields from Sale Order Lines to Invoice Lines

… tests + linting + JS for column not in fieldsInfo list

If a note line is put in first position, we get an error due to this missing condition. [UPD] Update sale_layout_category_hide_detail.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-reporting-13.0/sale-reporting-13.0-sale_layout_category_hide_detail Translate-URL: https://translation.odoo-community.org/projects/sale-reporting-13-0/sale-reporting-13-0-sale_layout_category_hide_detail/ [UPD] README.rst

Currently translated at 100.0% (11 of 11 strings) Translation: sale-reporting-13.0/sale-reporting-13.0-sale_layout_category_hide_detail Translate-URL: https://translation.odoo-community.org/projects/sale-reporting-13-0/sale-reporting-13-0-sale_layout_category_hide_detail/es/

Add a third clickable option on sections to hide all amounts in the detailed lines of a section. [UPD] Update sale_layout_category_hide_detail.pot sale_layout_category_hide_detail 13.0.1.1.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-reporting-13.0/sale-reporting-13.0-sale_layout_category_hide_detail Translate-URL: https://translation.odoo-community.org/projects/sale-reporting-13-0/sale-reporting-13-0-sale_layout_category_hide_detail/

francesco-ooops

@victoralmau is there any way to improve the layout? The three buttons are taking up to 25% of the sale order line width

especially in SOs without sections:

victoralmau · 2022-08-26T10:57:27Z

@victoralmau is there any way to improve the layout? The three buttons are taking up to 25% of the sale order line width

Although this in v13 is similar, I have applied the change to optimize space as much as possible.

francesco-ooops · 2022-08-26T11:06:45Z

@victoralmau is there any way to improve the layout? The three buttons are taking up to 25% of the sale order line width

Although this in v13 is similar, I have applied the change to optimize space as much as possible.

is there a specific reason for this fourth empty column? (sorry, I don't know the module very well and I don't see it in the past versions)

victoralmau · 2022-08-26T13:21:14Z

This column must be shown because depending on the corresponding use case, the corresponding icon will be shown or not.

francesco-ooops

Functional review ok!

pedrobaeza · 2022-08-29T09:17:04Z

/ocabot migration sale_layout_category_hide_detail

OCA-git-bot · 2022-08-29T09:17:25Z

The migration issue (#98) has been updated to reference the current pull request.
however, a previous pull request was referenced : #128.
Perhaps you should check that there is no duplicate work.
CC : @rousseldenis

sale_layout_category_hide_detail/static/src/js/boolean_fa_icon_widget.js

sale_layout_category_hide_detail/views/sale_order_report_templates.xml

elvise

LGTM!

… section line subtotal

…nt working

…shed invoices or confirmed orders. Related to: OCA#128 (comment) TT38579

…olumns of the buttons so that the table takes up as little space as possible. TT38579

… allow inheritability. TT38579

OCA-git-bot · 2022-09-01T14:50:41Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

francesco-ooops · 2022-09-01T16:09:42Z

@pedrobaeza good now?

pedrobaeza · 2022-09-01T16:30:00Z

/ocabot merge nobump

OCA-git-bot · 2022-09-01T16:30:14Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-170-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2022-09-01T16:36:02Z

Congratulations, your PR was merged at 87a2aeb. Thanks a lot for contributing to OCA. ❤️

francesco-ooops · 2022-09-02T16:32:39Z

@victoralmau could you fix urls to icons in description files?

@pedrobaeza this is an issue I've seen happening almost everytime there is an image/screenshot in description file, eg here, dunno if that's mentioned in guidelines or can be prevented differently

jeroenev

EDIT: line not correctly selected, see review below

sale_layout_category_hide_detail/static/src/js/boolean_fa_icon_widget.js

ernestotejeda and others added 14 commits August 26, 2022 09:34

sale_layout_category_hide_detail: New module

2a9bde2

Hide details for sections in sales orders and invoices for reports and customer portal

[MIG] sale_layout_category_hide_detail: Migration to 12.0

bd26d7f

[MIG] sale_layout_category_hide_detail: Migration scripts

4640ae6

[IMP] sale_layout_category_hide_detail: black, isort

4bf61b4

[MIG] sale_layout_category_hide_detail: Migration to 13.0

f466127

[FIX] sale_layout_category_hide_detail: Propagate 'Show details' to i…

4ffbee8

…nvoice" Propagate values in 'Show details' and 'Show subtotal' fields from Sale Order Lines to Invoice Lines

[FIX] sale_layout_category_hide_detail: Column rendering in section +…

e6c037c

… tests + linting + JS for column not in fieldsInfo list

Apply pre-commit

aea9eaf

[IMP] sale_layout_category_hide_detail: black, isort, prettier

1c806ff

[14.0][MIG] sale_layout_category_hide_detail

9e3b130

victoralmau mentioned this pull request Aug 26, 2022

[14.0][MIG] sale_layout_category_hide_detail #128

Closed

1 task

francesco-ooops reviewed Aug 26, 2022

View reviewed changes

francesco-ooops approved these changes Aug 29, 2022

View reviewed changes

OCA-git-bot added this to the 14.0 milestone Aug 29, 2022

OCA-git-bot mentioned this pull request Aug 29, 2022

Migration to version 14.0 #98

Closed

6 tasks

pedrobaeza reviewed Aug 29, 2022

View reviewed changes

sale_layout_category_hide_detail/static/src/js/boolean_fa_icon_widget.js Outdated Show resolved Hide resolved

sale_layout_category_hide_detail/views/sale_order_report_templates.xml Outdated Show resolved Hide resolved

elvise approved these changes Aug 29, 2022

View reviewed changes

OCA-git-bot added the approved label Aug 29, 2022

rousseldenis and others added 3 commits August 29, 2022 12:12

[14.0][IMP] sale_layout_category_hide_detail: Add possibility to hide…

3b1313f

… section line subtotal

[14.0][FIX] sale_layout_category_hide_detail: Make the hide line amou…

4f92c29

…nt working

[FIX] sale_layout_category_hide_detail: Do not allow changes to publi…

b75a1b7

…shed invoices or confirmed orders. Related to: OCA#128 (comment) TT38579

victoralmau added 2 commits August 29, 2022 12:14

[IMP] sale_layout_category_hide_detail: Apply a custom width to the c…

3a0e759

…olumns of the buttons so that the table takes up as little space as possible. TT38579

[IMP] sale_layout_category_hide_detail: Simplify code in functions to…

afb528c

… allow inheritability. TT38579

victoralmau force-pushed the 14.0-mig-sale_layout_category_hide_detail branch from 9e615af to afb528c Compare August 29, 2022 10:15

OCA-git-bot added the ready to merge label Sep 1, 2022

OCA-git-bot added the bot is merging ⏳ label Sep 1, 2022

OCA-git-bot merged commit a93708b into OCA:14.0 Sep 1, 2022

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Sep 1, 2022

victoralmau mentioned this pull request Sep 5, 2022

[14.0][FIX] sale_layout_category_hide_detail: Set the correct URL of the icons in readme. #171

Merged

jeroenev reviewed Sep 5, 2022

View reviewed changes

sale_layout_category_hide_detail/static/src/js/boolean_fa_icon_widget.js Show resolved Hide resolved

victoralmau mentioned this pull request Sep 6, 2022

[14.0][FIX] sale_layout_category_hide_detail: Remove unused code. #172

Merged

pedrobaeza deleted the 14.0-mig-sale_layout_category_hide_detail branch September 6, 2022 12:40

rousseldenis mentioned this pull request Oct 17, 2022

[14.0] sale_layout_category_hide_detail: Display subtotal title in a better manner #177

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0][MIG] sale_layout_category_hide_detail: Migration to 14.0 #170

[14.0][MIG] sale_layout_category_hide_detail: Migration to 14.0 #170

victoralmau commented Aug 26, 2022 •

edited

Loading

francesco-ooops left a comment •

edited

Loading

victoralmau commented Aug 26, 2022

francesco-ooops commented Aug 26, 2022

victoralmau commented Aug 26, 2022

francesco-ooops left a comment

pedrobaeza commented Aug 29, 2022

OCA-git-bot commented Aug 29, 2022

elvise left a comment

OCA-git-bot commented Sep 1, 2022

francesco-ooops commented Sep 1, 2022

pedrobaeza commented Sep 1, 2022

OCA-git-bot commented Sep 1, 2022

OCA-git-bot commented Sep 1, 2022

francesco-ooops commented Sep 2, 2022

jeroenev left a comment •

edited

Loading

[14.0][MIG] sale_layout_category_hide_detail: Migration to 14.0 #170

[14.0][MIG] sale_layout_category_hide_detail: Migration to 14.0 #170

Conversation

victoralmau commented Aug 26, 2022 • edited Loading

francesco-ooops left a comment • edited Loading

Choose a reason for hiding this comment

victoralmau commented Aug 26, 2022

francesco-ooops commented Aug 26, 2022

victoralmau commented Aug 26, 2022

francesco-ooops left a comment

Choose a reason for hiding this comment

pedrobaeza commented Aug 29, 2022

OCA-git-bot commented Aug 29, 2022

elvise left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Sep 1, 2022

francesco-ooops commented Sep 1, 2022

pedrobaeza commented Sep 1, 2022

OCA-git-bot commented Sep 1, 2022

OCA-git-bot commented Sep 1, 2022

francesco-ooops commented Sep 2, 2022

jeroenev left a comment • edited Loading

Choose a reason for hiding this comment

victoralmau commented Aug 26, 2022 •

edited

Loading

francesco-ooops left a comment •

edited

Loading

jeroenev left a comment •

edited

Loading