Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7.0 pep8 fix #10

Merged
merged 8 commits into from
Aug 7, 2014
Merged

7.0 pep8 fix #10

merged 8 commits into from
Aug 7, 2014

Conversation

eLBati
Copy link
Member

@eLBati eLBati commented Aug 7, 2014

No description provided.

@eLBati eLBati mentioned this pull request Aug 7, 2014
Closed
@pedrobaeza
Copy link
Member

Still some PEP8 erros:

./sale_dropshipping/purchase.py:98:73: E901 SyntaxError: invalid syntax
./sale_quotation_number/sale_quotation.py:22:1: F401 'fields' imported but unused
./sale_cancel_reason/model/sale.py:23:1: F401 '_' imported but unused
./sale_condition_text/condition.py:8:1: F401 'pooler' imported but unused
./sale_condition_text/sale_order.py:40:21: F821 undefined name '_'
./sale_condition_text/sale_order.py:41:21: F821 undefined name '_'

Regards.

@eLBati
Copy link
Member Author

eLBati commented Aug 7, 2014

On 08/07/2014 01:29 PM, Pedro M. Baeza wrote:

Still some PEP8 erros:

Fixed.
Thanks!

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 7db620c on eLBati:7.0_pep8_fix into * on OCA:7.0*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 1eac03e on eLBati:7.0_pep8_fix into * on OCA:7.0*.

bwrsandman
bwrsandman reviewed Aug 7, 2014
View reviewed changes
.travis.yml
@@ -17,7 +20,7 @@ install:

script:
- travis_run_flake8
- travis_run_tests
- travis_run_tests $HOME/product-attribute
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$HOME/product-attribute should no longer be needed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

|$HOME/product-attribute| should no longer me needed

Trying without

@bwrsandman
Copy link

👍

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling dab683c on eLBati:7.0_pep8_fix into * on OCA:7.0*.

@eLBati
Copy link
Member Author

eLBati commented Aug 7, 2014

It works without $HOME/product-attribute 👏

But we ran into OCA/maintainer-quality-tools#60 😔

@pedrobaeza
Copy link
Member

As the target of this PR is PEP8, I give my 👍

@rvalyi
Copy link
Member

rvalyi commented Aug 7, 2014

👍 thanks!

pedrobaeza added a commit that referenced this pull request Aug 7, 2014
@pedrobaeza
Merge pull request #10 from eLBati/7.0_pep8_fix
6ef5ea8 
PEP8 fix
@pedrobaeza pedrobaeza merged commit 6ef5ea8 into OCA:7.0 Aug 7, 2014
Tonow-c2c pushed a commit to Tonow-c2c/sale-workflow that referenced this pull request Aug 20, 2019
@leemannd
Merge pull request OCA#10 from leemannd/leemannd_add-sale_manual_deli…
00a4351 
…very

add Delivery Address to wizard. by default selec SO partner address.
lmignon pushed a commit to acsone/sale-workflow that referenced this pull request Feb 11, 2021
@guewen
Merge pull request OCA#10 from simahawk/shopfloor-scan-anything
530aa65 
Shopfloor cleanup data converters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@eLBati @pedrobaeza @coveralls @bwrsandman @rvalyi @OCA-git-bot